Skip to content

Commit 17bfcb9

Browse files
authored
Merge pull request #1318 from spring-cloud/gcp-jar-launcher
Attempts to micrate away from the classic loader
2 parents 78fdc24 + 5093c29 commit 17bfcb9

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,6 @@
4242
<artifactId>spring-boot-loader-tools</artifactId>
4343
<version>${spring-boot.version}</version>
4444
</dependency>
45-
<dependency>
46-
<groupId>org.springframework.boot</groupId>
47-
<artifactId>spring-boot-loader-classic</artifactId>
48-
<version>${spring-boot.version}</version>
49-
</dependency>
5045
<dependency>
5146
<groupId>org.springframework.boot</groupId>
5247
<artifactId>spring-boot-loader</artifactId>

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/main/java/org/springframework/cloud/function/adapter/gcp/GcfJarLauncher.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
import com.google.cloud.functions.HttpResponse;
2323
import com.google.cloud.functions.RawBackgroundFunction;
2424

25-
import org.springframework.boot.loader.JarLauncher;
26-
import org.springframework.boot.loader.jar.JarFile;
25+
import org.springframework.boot.loader.launch.JarLauncher;
2726

2827
/**
2928
* The launcher class written at the top-level of the output JAR to be deployed to
@@ -39,14 +38,15 @@ public class GcfJarLauncher extends JarLauncher implements HttpFunction, RawBack
3938
private final Object delegate;
4039

4140
public GcfJarLauncher() throws Exception {
42-
JarFile.registerUrlProtocolHandler();
41+
//JarFile.registerUrlProtocolHandler();
4342

44-
this.loader = createClassLoader(getClassPathArchivesIterator());
43+
this.loader = createClassLoader(getClassPathUrls());
4544

4645
Class<?> clazz = this.loader
4746
.loadClass("org.springframework.cloud.function.adapter.gcp.FunctionInvoker");
4847
this.delegate = clazz.getConstructor().newInstance();
4948
}
49+
5050
@Override
5151
public void service(HttpRequest httpRequest, HttpResponse httpResponse) throws Exception {
5252
Thread.currentThread().setContextClassLoader(this.loader);

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/main/java/org/springframework/cloud/function/adapter/gcp/layout/GcfJarLayout.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import org.springframework.boot.loader.tools.CustomLoaderLayout;
2222
import org.springframework.boot.loader.tools.Layouts;
2323
import org.springframework.boot.loader.tools.LoaderClassesWriter;
24-
import org.springframework.boot.loader.tools.LoaderImplementation;
2524
import org.springframework.cloud.function.adapter.gcp.GcfJarLauncher;
2625

2726
/**
@@ -47,7 +46,7 @@ public boolean isExecutable() {
4746

4847
@Override
4948
public void writeLoadedClasses(LoaderClassesWriter writer) throws IOException {
50-
writer.writeLoaderClasses(LoaderImplementation.CLASSIC);
49+
writer.writeLoaderClasses();
5150

5251
String jarName = LAUNCHER_NAME.replaceAll("\\.", "/") + ".class";
5352
writer.writeEntry(

0 commit comments

Comments
 (0)