Skip to content

Commit 762cfa5

Browse files
committed
Revert "Fix forward filter tests after change in Framework"
This reverts commit bde903a.
1 parent e083547 commit 762cfa5

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

spring-cloud-gateway-server-mvc/src/main/java/org/springframework/cloud/gateway/server/mvc/filter/ForwardedRequestHeadersFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public HttpHeaders apply(HttpHeaders input, ServerRequest request) {
162162
return;
163163
}
164164
int port = remoteAddress.getPort();
165-
if (port >= 0 && !forValue.contains(":")) {
165+
if (port >= 0) {
166166
forValue = forValue + ":" + port;
167167
}
168168
forwarded.put("for", forValue);

spring-cloud-gateway-server-mvc/src/test/java/org/springframework/cloud/gateway/server/mvc/filter/ForwardedRequestHeadersFilterTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.Map;
2626
import java.util.Optional;
2727

28-
import org.junit.jupiter.api.Disabled;
2928
import org.junit.jupiter.api.Test;
3029

3130
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -194,7 +193,7 @@ public void correctIPv6RemoteAddressMapping() throws UnknownHostException {
194193
assertThat(forwardeds).hasSize(1);
195194
Forwarded forwarded = forwardeds.get(0);
196195

197-
assertThat(forwarded.getValues()).containsEntry("for", "\"2001:db8:cafe:0:0:0:0:17:80\"");
196+
assertThat(forwarded.getValues()).containsEntry("for", "\"[2001:db8:cafe:0:0:0:0:17]:80\"");
198197
}
199198

200199
@Test
@@ -298,8 +297,7 @@ public void untrustedForwardedForNotAppended() throws Exception {
298297
}
299298

300299
@Test
301-
@Disabled("Change in Framework broke this test, see https://github.com/spring-projects/spring-framework/commit/2c831449464d677b2a865ad02718994b3c69a338")
302-
public void remoteAddressIsNullUnTrustedProxyNotAppended() throws Exception {
300+
public void remoteAdddressIsNullUnTrustedProxyNotAppended() throws Exception {
303301
MockHttpServletRequest servletRequest = MockMvcRequestBuilders.get("http://localhost/get")
304302
.header(HttpHeaders.HOST, "myhost")
305303
.header(FORWARDED_HEADER, "proto=http;host=myhost;for=127.0.0.1")

0 commit comments

Comments
 (0)