-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Open
Labels
Description
Describe the bug
#2981 introduced SslBundle
support which BTW a really nice feature.
However SslOptions
of the bundle is not honored by the implementation.
E.g. the gateway user would like to restrict the cipher suites of the outbound http client via SslBundle features. (or disable a protocol).
Sample
This specific implementation
Lines 71 to 73 in 093f405
if (bundle != null) { | |
sslContextBuilder.keyManager(bundle.getManagers().getKeyManagerFactory()); | |
} |
misses the following:
SslOptions sslOptions = bundle.getOptions();
if (sslOptions != null && sslOptions.isSpecified()) {
sslContextBuilder.ciphers(SslOptions.asSet(sslOptions.getCiphers()));
sslContextBuilder.protocols(sslOptions.getEnabledProtocols());
}
I guess the GrpcSslConfigurer as well misses the same thing since it was also modified when #2981 solved by this commit 0600b4d