Skip to content

Commit 073af1f

Browse files
committed
Merge branch 'main' into fix-1715-drop-profiles-support
2 parents 4066344 + f9a678c commit 073af1f

File tree

57 files changed

+1477
-3392
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+1477
-3392
lines changed

.github/dependabot.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ updates:
2020
- dependency-name: "*"
2121
update-types:
2222
- version-update:semver-major
23+
- version-update:semver-minor
2324
- package-ecosystem: maven
2425
directory: /
2526
schedule:
@@ -31,6 +32,17 @@ updates:
3132
update-types:
3233
- version-update:semver-major
3334
- version-update:semver-minor
35+
- package-ecosystem: maven
36+
directory: /
37+
schedule:
38+
interval: daily
39+
target-branch: 3.2.x
40+
ignore:
41+
# only upgrade by minor or patch
42+
- dependency-name: "*"
43+
update-types:
44+
- version-update:semver-major
45+
- version-update:semver-minor
3446
- package-ecosystem: npm
3547
target-branch: docs-build
3648
directory: /
@@ -46,3 +58,8 @@ updates:
4658
directory: /docs
4759
schedule:
4860
interval: weekly
61+
- package-ecosystem: npm
62+
target-branch: 3.2.x
63+
directory: /docs
64+
schedule:
65+
interval: weekly

.github/workflows/composites/maven-build-with-dry-run-for-tests/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
shell: bash
99
run: |
1010
./mvnw install -B \
11-
-Dskip.build.image=true \
11+
-Dspring-boot.build-image.skip=true \
1212
-DskipTests -DskipITs \
1313
-T 1C -U -q
1414

.github/workflows/composites/pre-test-actions/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ runs:
2424
- name: build project
2525
shell: bash
2626
run: |
27-
./mvnw clean install -Dskip.build.image=true -DskipITs -DskipTests -T1C -U -B -q
27+
./mvnw clean install -Dspring-boot.build-image.skip=true -DskipITs -DskipTests -T1C -U -B -q
2828
2929
- name: build controllers project
3030
uses: ./.github/workflows/composites/build-controllers-project

.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ runs:
4747
-Dmaven.wagon.http.pool=false \
4848
-Dmaven.wagon.http.retryHandler.class=standard \
4949
-Dmaven.wagon.http.retryHandler.count=3 \
50-
-Dskip.build.image=true
50+
-Dspring-boot.build-image.skip=true
5151
5252
touch /tmp/test_times_${{ env.CURRENT_INDEX }}.txt
5353

.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ runs:
156156
-Dmaven.wagon.http.pool=false \
157157
-Dmaven.wagon.http.retryHandler.class=standard \
158158
-Dmaven.wagon.http.retryHandler.count=3 \
159-
-Dskip.build.image=true
159+
-Dspring-boot.build-image.skip=true
160160

161161
touch /tmp/test_times_${{ env.CURRENT_INDEX }}.txt
162162

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
"@antora/collector-extension": "1.0.1",
66
"@asciidoctor/tabs": "1.0.0-beta.6",
77
"@springio/antora-extensions": "1.14.2",
8-
"@springio/asciidoctor-extensions": "1.0.0-alpha.14"
8+
"@springio/asciidoctor-extensions": "1.0.0-alpha.16"
99
}
1010
}

spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/ConfigUtils.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,11 @@ public static <T> void registerSingle(ConfigurableBootstrapContext bootstrapCont
312312
String name, ApplicationListener<?> listener) {
313313
bootstrapContext.registerIfAbsent(cls, BootstrapRegistry.InstanceSupplier.of(instance));
314314
bootstrapContext.addCloseListener(event -> {
315-
if (event.getApplicationContext().getBeanFactory().getSingleton(name) == null) {
316-
event.getApplicationContext()
317-
.getBeanFactory()
318-
.registerSingleton(name, event.getBootstrapContext().get(cls));
315+
316+
T singleton = event.getBootstrapContext().get(cls);
317+
318+
if (event.getApplicationContext().getBeanFactory().getSingleton(name) == null && singleton != null) {
319+
event.getApplicationContext().getBeanFactory().registerSingleton(name, singleton);
319320
event.getApplicationContext().addApplicationListener(listener);
320321
}
321322
});

spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/KubernetesConfigDataLocationResolver.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
public abstract class KubernetesConfigDataLocationResolver
5353
implements ConfigDataLocationResolver<KubernetesConfigDataResource>, Ordered {
5454

55+
private static final Class<KubernetesClientProperties> PROPERTIES_CLASS = KubernetesClientProperties.class;
56+
5557
private static final boolean RETRY_IS_PRESENT = isPresent("org.springframework.retry.annotation.Retryable", null);
5658

5759
private final Log log;
@@ -139,8 +141,7 @@ private void registerProperties(ConfigDataLocationResolverContext resolverContex
139141
SecretsConfigProperties secretsProperties) {
140142

141143
ConfigurableBootstrapContext bootstrapContext = resolverContext.getBootstrapContext();
142-
registerSingle(bootstrapContext, KubernetesClientProperties.class, clientProperties,
143-
"configDataKubernetesClientProperties");
144+
registerSingle(bootstrapContext, PROPERTIES_CLASS, clientProperties, "configDataKubernetesClientProperties");
144145

145146
if (configMapProperties != null) {
146147
registerSingle(bootstrapContext, ConfigMapConfigProperties.class, configMapProperties,
@@ -174,15 +175,14 @@ private static PropertyHolder of(ConfigDataLocationResolverContext context) {
174175
private static KubernetesClientProperties clientProperties(ConfigDataLocationResolverContext context,
175176
String namespace) {
176177
KubernetesClientProperties kubernetesClientProperties;
178+
ConfigurableBootstrapContext bootstrapContext = context.getBootstrapContext();
177179

178-
if (context.getBootstrapContext().isRegistered(KubernetesClientProperties.class)) {
179-
kubernetesClientProperties = context.getBootstrapContext()
180-
.get(KubernetesClientProperties.class)
181-
.withNamespace(namespace);
180+
if (bootstrapContext.isRegistered(PROPERTIES_CLASS) && bootstrapContext.get(PROPERTIES_CLASS) != null) {
181+
kubernetesClientProperties = bootstrapContext.get(PROPERTIES_CLASS).withNamespace(namespace);
182182
}
183183
else {
184184
kubernetesClientProperties = context.getBinder()
185-
.bindOrCreate(KubernetesClientProperties.PREFIX, Bindable.of(KubernetesClientProperties.class))
185+
.bindOrCreate(KubernetesClientProperties.PREFIX, Bindable.of(PROPERTIES_CLASS))
186186
.withNamespace(namespace);
187187
}
188188

spring-cloud-kubernetes-controllers/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
<executions>
3434
<execution>
3535
<id>build-image</id>
36-
<configuration>
37-
<skip>${skip.build.image}</skip>
38-
</configuration>
3936
<phase>package</phase>
4037
<goals>
4138
<goal>build-image-no-fork</goal>

spring-cloud-kubernetes-dependencies/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
<name>Spring Cloud Kubernetes :: Dependencies</name>
3333
<description>Spring Cloud Kubernetes Dependencies</description>
3434
<properties>
35-
<kubernetes-fabric8-client.version>6.13.4</kubernetes-fabric8-client.version>
35+
<kubernetes-fabric8-client.version>6.13.5</kubernetes-fabric8-client.version>
3636
<kubernetes-native-client.version>19.0.2</kubernetes-native-client.version>
37-
<wiremock.version>3.4.2</wiremock.version>
37+
<wiremock.version>3.9.2</wiremock.version>
3838
</properties>
3939
<dependencyManagement>
4040
<dependencies>

0 commit comments

Comments
 (0)