Skip to content

Commit 7612ac3

Browse files
committed
fix test
Signed-off-by: wind57 <[email protected]>
1 parent 390188a commit 7612ac3

File tree

2 files changed

+11
-6
lines changed
  • spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons

2 files changed

+11
-6
lines changed

spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/fabric8_client/Util.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ else if (phase.equals(Phase.DELETE)) {
132132
}
133133
}
134134

135-
public void deleteAndWait(String namespace, @Nullable Deployment deployment, Service service) {
135+
public void deleteAndWait(String namespace, @Nullable Deployment deployment, @Nullable Service service) {
136136
try {
137137

138138
long startTime = System.currentTimeMillis();
@@ -150,8 +150,10 @@ public void deleteAndWait(String namespace, @Nullable Deployment deployment, Ser
150150
}
151151
System.out.println("Ended deployment delete in " + (System.currentTimeMillis() - startTime) + "ms");
152152

153-
client.services().inNamespace(namespace).resource(service).delete();
154-
waitForServiceToBeDeleted(namespace, service);
153+
if (service != null) {
154+
client.services().inNamespace(namespace).resource(service).delete();
155+
waitForServiceToBeDeleted(namespace, service);
156+
}
155157

156158
}
157159
catch (Exception e) {

spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/native_client/Util.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,13 @@ public void deleteAndWait(String namespace, V1Deployment deployment, V1Service s
209209
waitForDeploymentToBeDeleted(deploymentName, namespace);
210210
waitForDeploymentPodsToBeDeleted(podLabels, namespace);
211211

212-
service.getMetadata().setNamespace(namespace);
213-
coreV1Api.deleteNamespacedService(service.getMetadata().getName(), service.getMetadata().getNamespace(),
212+
if (service != null) {
213+
service.getMetadata().setNamespace(namespace);
214+
coreV1Api.deleteNamespacedService(service.getMetadata().getName(), service.getMetadata().getNamespace(),
214215
null, null, null, null, null, null);
215-
waitForServiceToBeDeleted(service.getMetadata().getName(), namespace);
216+
waitForServiceToBeDeleted(service.getMetadata().getName(), namespace);
217+
}
218+
216219
}
217220
catch (Exception e) {
218221
throw new RuntimeException(e);

0 commit comments

Comments
 (0)