Skip to content

Commit 8bfbfa7

Browse files
committed
fix tests
Signed-off-by: wind57 <[email protected]>
1 parent 05859a3 commit 8bfbfa7

File tree

2 files changed

+15
-5
lines changed
  • spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-discovery/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/discovery
  • spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/fabric8_client

2 files changed

+15
-5
lines changed

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-discovery/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/discovery/Fabric8DiscoveryFilterIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ void beforeEach() {
5151
util.createNamespace(NAMESPACE_A_UAT);
5252
util.createNamespace(NAMESPACE_B_UAT);
5353

54-
util.wiremock(NAMESPACE_A_UAT, Phase.CREATE);
55-
util.wiremock(NAMESPACE_B_UAT, Phase.CREATE);
54+
util.wiremock(NAMESPACE_A_UAT, Phase.CREATE, false);
55+
util.wiremock(NAMESPACE_B_UAT, Phase.CREATE, false);
5656

5757
}
5858

5959
@AfterEach
6060
void afterEach() {
6161

62-
util.wiremock(NAMESPACE_A_UAT, Phase.DELETE);
63-
util.wiremock(NAMESPACE_B_UAT, Phase.DELETE);
62+
util.wiremock(NAMESPACE_A_UAT, Phase.DELETE, false);
63+
util.wiremock(NAMESPACE_B_UAT, Phase.DELETE, false);
6464

6565
util.deleteNamespace(NAMESPACE_A_UAT);
6666
util.deleteNamespace(NAMESPACE_B_UAT);

spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/fabric8_client/Util.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,12 @@ private void waitForConfigMap(String namespace, ConfigMap configMap, Phase phase
295295
});
296296
}
297297

298-
public void wiremock(String namespace, Phase phase) {
298+
/**
299+
* 'withNodePort' specifies if we add the NodePort or not. It is needed because we
300+
* sometimes deploy two instances of wiremock, and they can't have the same NodePort
301+
* exposed
302+
*/
303+
public void wiremock(String namespace, Phase phase, boolean withNodePort) {
299304
InputStream deploymentStream = inputStream("wiremock/wiremock-deployment.yaml");
300305
InputStream serviceStream = inputStream("wiremock/wiremock-service.yaml");
301306

@@ -305,6 +310,11 @@ public void wiremock(String namespace, Phase phase) {
305310
deployment.getSpec().getTemplate().getSpec().getContainers().get(0).setImage(imageWithVersion);
306311

307312
Service service = client.services().load(serviceStream).item();
313+
if (!withNodePort) {
314+
// we assume we only have one 'http' port
315+
service.getSpec().getPorts().get(0).setNodePort(null);
316+
service.getSpec().setType("ClusterIP");
317+
}
308318

309319
if (phase.equals(Phase.CREATE)) {
310320
deployment.getMetadata().setNamespace(namespace);

0 commit comments

Comments
 (0)