Skip to content

Commit ae2b8ad

Browse files
authored
Merge pull request #2029 from wind57/drop_overlapping_methods
2 parents 1289b88 + d403658 commit ae2b8ad

File tree

3 files changed

+3
-8
lines changed
  • spring-cloud-kubernetes-commons/src
  • spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config

3 files changed

+3
-8
lines changed

spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/ConfigUtils.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,6 @@ public static String sourceName(String target, String applicationName, String na
169169
return name;
170170
}
171171

172-
public static MultipleSourcesContainer processNamedData(List<StrippedSourceContainer> strippedSources,
173-
Environment environment, LinkedHashSet<String> sourceNames, String namespace, boolean decode) {
174-
return processNamedData(strippedSources, environment, sourceNames, namespace, decode, true);
175-
}
176-
177172
/**
178173
* Transforms raw data from one or multiple sources into an entry of source names and
179174
* flattened data that they all hold (potentially overriding entries without any

spring-cloud-kubernetes-commons/src/test/java/org/springframework/cloud/kubernetes/commons/config/ConfigUtilsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ void testMerge() {
162162
.collect(Collectors.toCollection(LinkedHashSet::new));
163163

164164
MultipleSourcesContainer result = ConfigUtils.processNamedData(List.of(configMapOne, configMapOneK8s),
165-
new MockEnvironment(), sourceNames, "default", false);
165+
new MockEnvironment(), sourceNames, "default", false, true);
166166

167167
Assertions.assertThat(result.data().size()).isEqualTo(2);
168168
Map<String, Object> one = result.data().get("configmap-one");

spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/Fabric8ConfigUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ static MultipleSourcesContainer secretsDataByName(KubernetesClient client, Strin
107107
if (strippedSecrets.isEmpty()) {
108108
return MultipleSourcesContainer.empty();
109109
}
110-
return ConfigUtils.processNamedData(strippedSecrets, environment, sourceNames, namespace, true);
110+
return ConfigUtils.processNamedData(strippedSecrets, environment, sourceNames, namespace, true, true);
111111
}
112112

113113
/**
@@ -124,7 +124,7 @@ static MultipleSourcesContainer configMapsDataByName(KubernetesClient client, St
124124
if (strippedConfigMaps.isEmpty()) {
125125
return MultipleSourcesContainer.empty();
126126
}
127-
return ConfigUtils.processNamedData(strippedConfigMaps, environment, sourceNames, namespace, false);
127+
return ConfigUtils.processNamedData(strippedConfigMaps, environment, sourceNames, namespace, false, true);
128128
}
129129

130130
private static List<StrippedSourceContainer> strippedConfigMaps(KubernetesClient client, String namespace) {

0 commit comments

Comments
 (0)