Skip to content

Commit b8d7de3

Browse files
authored
Merge pull request #2067 from wind57/rename-external-name-class
Rename external name class (5)
2 parents 2139b2c + 4a58ff5 commit b8d7de3

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

spring-cloud-kubernetes-client-discovery/src/test/java/org/springframework/cloud/kubernetes/client/discovery/KubernetesClientInformerDiscoveryClientTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252

5353
import org.springframework.cloud.client.ServiceInstance;
5454
import org.springframework.cloud.kubernetes.commons.discovery.DefaultKubernetesServiceInstance;
55+
import org.springframework.cloud.kubernetes.commons.discovery.ExternalNameKubernetesServiceInstance;
5556
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
56-
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesExternalNameServiceInstance;
5757

5858
import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
5959
import static org.assertj.core.api.Assertions.assertThat;
@@ -571,7 +571,7 @@ void testExternalNameService() {
571571

572572
List<ServiceInstance> result = discoveryClient.getInstances("blue-service");
573573
assertThat(result.size()).isEqualTo(1);
574-
KubernetesExternalNameServiceInstance externalNameServiceInstance = (KubernetesExternalNameServiceInstance) result
574+
ExternalNameKubernetesServiceInstance externalNameServiceInstance = (ExternalNameKubernetesServiceInstance) result
575575
.get(0);
576576
assertThat(externalNameServiceInstance.getServiceId()).isEqualTo("blue-service");
577577
assertThat(externalNameServiceInstance.getHost()).isEqualTo("k8s-spring-b");

spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/discovery/DiscoveryClientUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public static ServiceInstance externalNameServiceInstance(ServiceMetadata servic
164164

165165
InstanceIdHostPodName data = instanceIdAndHost.get();
166166

167-
return new KubernetesExternalNameServiceInstance(serviceMetadata.name(), data.host(), data.instanceId(),
167+
return new ExternalNameKubernetesServiceInstance(serviceMetadata.name(), data.host(), data.instanceId(),
168168
serviceInstanceMetadata);
169169

170170
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*
2929
* @author wind57
3030
*/
31-
public record KubernetesExternalNameServiceInstance(String serviceId, String host, String instanceId,
31+
public record ExternalNameKubernetesServiceInstance(String serviceId, String host, String instanceId,
3232
Map<String, String> metadata) implements ServiceInstance, Serializable {
3333

3434
@Override

spring-cloud-kubernetes-commons/src/test/java/org/springframework/cloud/kubernetes/commons/discovery/ServiceInstanceSerializationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ void defaultKubernetesServiceInstanceDeserializationTest() throws JsonProcessing
123123

124124
@Test
125125
void externalNameServiceInstanceSerializationTest() throws JsonProcessingException {
126-
KubernetesExternalNameServiceInstance instance = new KubernetesExternalNameServiceInstance("serviceId", "host",
126+
ExternalNameKubernetesServiceInstance instance = new ExternalNameKubernetesServiceInstance("serviceId", "host",
127127
"instanceId", Map.of("a", "b"));
128128
String serialized = new ObjectMapper().writeValueAsString(instance);
129129

spring-cloud-kubernetes-fabric8-discovery/src/test/java/org/springframework/cloud/kubernetes/fabric8/discovery/Fabric8DiscoveryClientTwoTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
import org.springframework.cloud.client.ServiceInstance;
4545
import org.springframework.cloud.kubernetes.commons.KubernetesNamespaceProvider;
4646
import org.springframework.cloud.kubernetes.commons.discovery.DefaultKubernetesServiceInstance;
47+
import org.springframework.cloud.kubernetes.commons.discovery.ExternalNameKubernetesServiceInstance;
4748
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
48-
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesExternalNameServiceInstance;
4949
import org.springframework.core.env.Environment;
5050
import org.springframework.mock.env.MockEnvironment;
5151

@@ -553,7 +553,7 @@ void testExternalNameService() {
553553
Fabric8DiscoveryClient discoveryClient = new Fabric8DiscoveryClient(client, properties, null, null, null);
554554
List<ServiceInstance> result = discoveryClient.getInstances("blue-service");
555555
Assertions.assertThat(result.size()).isEqualTo(1);
556-
KubernetesExternalNameServiceInstance externalNameServiceInstance = (KubernetesExternalNameServiceInstance) result
556+
ExternalNameKubernetesServiceInstance externalNameServiceInstance = (ExternalNameKubernetesServiceInstance) result
557557
.get(0);
558558
Assertions.assertThat(externalNameServiceInstance.getServiceId()).isEqualTo("blue-service");
559559
Assertions.assertThat(externalNameServiceInstance.getHost()).isEqualTo("k8s-spring-b");

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-k8s-client-discovery/src/test/java/org/springframework/cloud/kubernetes/k8s/client/discovery/KubernetesClientDiscoverySimpleIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
import org.springframework.cloud.client.ServiceInstance;
3535
import org.springframework.cloud.client.discovery.DiscoveryClient;
3636
import org.springframework.cloud.kubernetes.commons.discovery.DefaultKubernetesServiceInstance;
37+
import org.springframework.cloud.kubernetes.commons.discovery.ExternalNameKubernetesServiceInstance;
3738
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
38-
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesExternalNameServiceInstance;
3939
import org.springframework.cloud.kubernetes.integration.tests.commons.Images;
4040
import org.springframework.cloud.kubernetes.integration.tests.commons.Phase;
4141
import org.springframework.context.annotation.Bean;
@@ -134,7 +134,7 @@ private void testCustomAnnotation(List<ServiceInstance> instances) {
134134
}
135135

136136
private void testExternalNameService(DiscoveryClient discoveryClient) {
137-
KubernetesExternalNameServiceInstance externalNameService = (KubernetesExternalNameServiceInstance) discoveryClient
137+
ExternalNameKubernetesServiceInstance externalNameService = (ExternalNameKubernetesServiceInstance) discoveryClient
138138
.getInstances("external-name-service")
139139
.get(0);
140140

0 commit comments

Comments
 (0)