Skip to content

Commit be7a2bf

Browse files
committed
Merge branch 'clean-up-after-breaking-changes' into refactor_without_k3s
2 parents 6cd6a2d + b1ce8f1 commit be7a2bf

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

spring-cloud-kubernetes-commons/src/test/java/org/springframework/cloud/kubernetes/commons/configdata/KubernetesConfigDataLocationResolverTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,11 @@ void testResolveProfileSpecificSix() {
289289
Mockito.when(RESOLVER_CONTEXT.getBinder()).thenReturn(binder);
290290
Mockito.when(RESOLVER_CONTEXT.getBootstrapContext()).thenReturn(new DefaultBootstrapContext());
291291

292+
Profiles profiles = Mockito.mock(Profiles.class);
293+
ConfigDataLocation configDataLocation = ConfigDataLocation.of("kubernetes:abc");
294+
storePropertiesResolver.resolveProfileSpecific(RESOLVER_CONTEXT,
295+
configDataLocation, profiles);
296+
292297
// on the other hand, @Default will be picked here
293298
Assertions.assertThat(storePropertiesResolver.configMapConfigProperties.enabled()).isTrue();
294299

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-discovery/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/discovery/TestAssertions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ static void assertAllServices(DiscoveryClient discoveryClient) {
111111
.isEqualTo(Map.of("k8s_namespace", "default", "type", "ExternalName"));
112112
assertThat(externalNameInstance.isSecure()).isFalse();
113113
assertThat(externalNameInstance.getUri().toASCIIString()).isEqualTo("spring.io");
114-
assertThat(externalNameInstance.getScheme()).isEqualTo("http");
114+
assertThat(externalNameInstance.getScheme()).isNull();
115115
}
116116

117117
/**

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-k8s-client-discovery/src/test/java/org/springframework/cloud/kubernetes/k8s/client/discovery/KubernetesClientDiscoverySimpleIT.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.springframework.cloud.client.discovery.DiscoveryClient;
3636
import org.springframework.cloud.kubernetes.commons.discovery.DefaultKubernetesServiceInstance;
3737
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
38+
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesExternalNameServiceInstance;
3839
import org.springframework.cloud.kubernetes.integration.tests.commons.Images;
3940
import org.springframework.cloud.kubernetes.integration.tests.commons.Phase;
4041
import org.springframework.context.annotation.Bean;
@@ -133,7 +134,7 @@ private void testCustomAnnotation(List<ServiceInstance> instances) {
133134
}
134135

135136
private void testExternalNameService(DiscoveryClient discoveryClient) {
136-
DefaultKubernetesServiceInstance externalNameService = (DefaultKubernetesServiceInstance) discoveryClient
137+
KubernetesExternalNameServiceInstance externalNameService = (KubernetesExternalNameServiceInstance) discoveryClient
137138
.getInstances("external-name-service")
138139
.get(0);
139140

@@ -144,7 +145,7 @@ private void testExternalNameService(DiscoveryClient discoveryClient) {
144145
.containsAllEntriesOf(Map.of("k8s_namespace", "default", "type", "ExternalName"));
145146
assertThat(externalNameService.isSecure()).isFalse();
146147
assertThat(externalNameService.getUri().toASCIIString()).isEqualTo("spring.io");
147-
assertThat(externalNameService.getScheme()).isEqualTo("http");
148+
assertThat(externalNameService.getScheme()).isNull();
148149
}
149150

150151
// https://github.com/spring-cloud/spring-cloud-kubernetes/issues/1286

0 commit comments

Comments
 (0)