Skip to content

Commit cd3dc11

Browse files
committed
Merge branch '3.0.x'
2 parents 548a43a + d96c7c8 commit cd3dc11

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

spring-cloud-kubernetes-discovery/src/main/java/org/springframework/cloud/kubernetes/discovery/KubernetesDiscoveryClient.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ public List<ServiceInstance> getInstances(String serviceId) {
8080
public List<String> getServices() {
8181
Service[] services = rest.getForEntity(discoveryServerUrl + "/apps", Service[].class).getBody();
8282
if (services != null && services.length > 0) {
83-
return Arrays.stream(services).filter(this::matchNamespaces).map(Service::getName)
84-
.collect(Collectors.toList());
83+
return Arrays.stream(services).filter(this::matchNamespaces).map(Service::getName).toList();
8584
}
8685
return List.of();
8786
}

spring-cloud-kubernetes-discovery/src/main/java/org/springframework/cloud/kubernetes/discovery/KubernetesDiscoveryClientReactiveAutoConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.springframework.cloud.kubernetes.commons.discovery.ConditionalOnSpringCloudKubernetesReactiveDiscovery;
2525
import org.springframework.cloud.kubernetes.commons.discovery.ConditionalOnSpringCloudKubernetesReactiveDiscoveryHealthInitializer;
2626
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryClientHealthIndicatorInitializer;
27+
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
2728
import org.springframework.context.ApplicationEventPublisher;
2829
import org.springframework.context.annotation.Bean;
2930
import org.springframework.context.annotation.Configuration;
@@ -34,8 +35,7 @@
3435
*/
3536
@Configuration(proxyBeanMethods = false)
3637
@ConditionalOnSpringCloudKubernetesReactiveDiscovery
37-
@EnableConfigurationProperties({ DiscoveryClientHealthIndicatorProperties.class,
38-
KubernetesDiscoveryClientProperties.class })
38+
@EnableConfigurationProperties({ DiscoveryClientHealthIndicatorProperties.class, KubernetesDiscoveryProperties.class })
3939
class KubernetesDiscoveryClientReactiveAutoConfiguration {
4040

4141
@Bean
@@ -47,7 +47,7 @@ WebClient.Builder webClientBuilder() {
4747
@Bean
4848
@ConditionalOnMissingBean
4949
KubernetesReactiveDiscoveryClient kubernetesReactiveDiscoveryClient(WebClient.Builder webClientBuilder,
50-
KubernetesDiscoveryClientProperties properties) {
50+
KubernetesDiscoveryProperties properties) {
5151
return new KubernetesReactiveDiscoveryClient(webClientBuilder, properties);
5252
}
5353

spring-cloud-kubernetes-discovery/src/main/java/org/springframework/cloud/kubernetes/discovery/KubernetesReactiveDiscoveryClient.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.springframework.cache.annotation.Cacheable;
2222
import org.springframework.cloud.client.ServiceInstance;
2323
import org.springframework.cloud.client.discovery.ReactiveDiscoveryClient;
24+
import org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties;
2425
import org.springframework.util.StringUtils;
2526
import org.springframework.web.reactive.function.client.WebClient;
2627

@@ -31,6 +32,7 @@ public class KubernetesReactiveDiscoveryClient implements ReactiveDiscoveryClien
3132

3233
private final WebClient webClient;
3334

35+
@Deprecated(forRemoval = true)
3436
public KubernetesReactiveDiscoveryClient(WebClient.Builder webClientBuilder,
3537
KubernetesDiscoveryClientProperties properties) {
3638
if (!StringUtils.hasText(properties.getDiscoveryServerUrl())) {
@@ -39,6 +41,13 @@ public KubernetesReactiveDiscoveryClient(WebClient.Builder webClientBuilder,
3941
this.webClient = webClientBuilder.baseUrl(properties.getDiscoveryServerUrl()).build();
4042
}
4143

44+
KubernetesReactiveDiscoveryClient(WebClient.Builder webClientBuilder, KubernetesDiscoveryProperties properties) {
45+
if (!StringUtils.hasText(properties.discoveryServerUrl())) {
46+
throw new DiscoveryServerUrlInvalidException();
47+
}
48+
this.webClient = webClientBuilder.baseUrl(properties.discoveryServerUrl()).build();
49+
}
50+
4251
@Override
4352
public String description() {
4453
return "Reactive Kubernetes Discovery Client";

0 commit comments

Comments
 (0)