Skip to content

Commit e544388

Browse files
authored
rbac clean-up in integration tests (#1447)
* fix issue * fix issue
1 parent fb656dd commit e544388

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-discoveryclient-it/src/test/java/org/springframework/cloud/kubernetes/discoveryclient/it/DiscoveryClientFilterNamespaceIT.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ class DiscoveryClientFilterNamespaceIT {
7171

7272
private static RbacAuthorizationV1Api rbacApi;
7373

74+
private static V1ClusterRoleBinding clusterRoleBinding;
75+
7476
@BeforeAll
7577
static void beforeAll() throws Exception {
7678
K3S.start();
@@ -83,18 +85,20 @@ static void beforeAll() throws Exception {
8385

8486
util = new Util(K3S);
8587
rbacApi = new RbacAuthorizationV1Api();
88+
clusterRoleBinding = (V1ClusterRoleBinding) util
89+
.yaml("namespace-filter/cluster-admin-serviceaccount-role.yaml");
8690
util.createNamespace(NAMESPACE_LEFT);
8791
util.createNamespace(NAMESPACE_RIGHT);
8892
util.setUp(NAMESPACE);
8993

90-
V1ClusterRoleBinding clusterRole = (V1ClusterRoleBinding) util
91-
.yaml("namespace-filter/cluster-admin-serviceaccount-role.yaml");
92-
rbacApi.createClusterRoleBinding(clusterRole, null, null, null, null);
94+
rbacApi.createClusterRoleBinding(clusterRoleBinding, null, null, null, null);
9395
discoveryServer(Phase.CREATE);
9496
}
9597

9698
@AfterAll
9799
static void afterAll() throws Exception {
100+
rbacApi.deleteClusterRoleBinding(clusterRoleBinding.getMetadata().getName(), null, null, null, null, null,
101+
null);
98102
Commons.cleanUp(DISCOVERY_SERVER_APP_NAME, K3S);
99103
Commons.cleanUp(SPRING_CLOUD_K8S_DISCOVERY_CLIENT_APP_NAME, K3S);
100104
discoveryServer(Phase.DELETE);

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-discoveryclient-it/src/test/java/org/springframework/cloud/kubernetes/discoveryclient/it/DiscoveryClientIT.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@ class DiscoveryClientIT {
113113

114114
private static Util util;
115115

116+
private static RbacAuthorizationV1Api rbacApi;
117+
118+
private static V1ClusterRoleBinding clusterRoleBinding;
119+
116120
@BeforeAll
117121
static void beforeAll() throws Exception {
118122
K3S.start();
@@ -124,15 +128,15 @@ static void beforeAll() throws Exception {
124128
Commons.loadSpringCloudKubernetesImage(SPRING_CLOUD_K8S_DISCOVERY_CLIENT_APP_NAME, K3S);
125129

126130
util = new Util(K3S);
131+
rbacApi = new RbacAuthorizationV1Api();
127132
util.setUp(NAMESPACE);
128133

129134
util.createNamespace(NAMESPACE_LEFT);
130135
util.createNamespace(NAMESPACE_RIGHT);
131136

132-
RbacAuthorizationV1Api rbacApi = new RbacAuthorizationV1Api();
133-
V1ClusterRoleBinding clusterRole = (V1ClusterRoleBinding) util
137+
clusterRoleBinding = (V1ClusterRoleBinding) util
134138
.yaml("namespace-filter/cluster-admin-serviceaccount-role.yaml");
135-
rbacApi.createClusterRoleBinding(clusterRole, null, null, null, null);
139+
rbacApi.createClusterRoleBinding(clusterRoleBinding, null, null, null, null);
136140

137141
util.wiremock(NAMESPACE_LEFT, "/wiremock-" + NAMESPACE_LEFT, Phase.CREATE, false);
138142
util.wiremock(NAMESPACE_RIGHT, "/wiremock-" + NAMESPACE_RIGHT, Phase.CREATE, false);
@@ -143,6 +147,8 @@ static void beforeAll() throws Exception {
143147

144148
@AfterAll
145149
static void afterAll() throws Exception {
150+
rbacApi.deleteClusterRoleBinding(clusterRoleBinding.getMetadata().getName(), null, null, null, null, null,
151+
null);
146152
Commons.cleanUp(DISCOVERY_SERVER_APP_NAME, K3S);
147153
Commons.cleanUp(SPRING_CLOUD_K8S_DISCOVERY_CLIENT_APP_NAME, K3S);
148154

0 commit comments

Comments
 (0)