Skip to content

Commit ea9d648

Browse files
committed
Improve assertions
When the isEqualTo assertion is not met, the error message only states that the value was something other than 2. When the hasSize assertion is not met, the error message includes the contents of the map. This makes it easier to determine what's missing. Signed-off-by: Andy Wilkinson <[email protected]>
1 parent 28cea82 commit ea9d648

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

spring-cloud-kubernetes-client-discovery/src/test/java/org/springframework/cloud/kubernetes/client/discovery/reactive/KubernetesInformerReactiveDiscoveryClientAutoConfigurationApplicationContextTests.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void discoveryEnabledDefault() {
7474
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
7575

7676
// simple from commons and ours
77-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
77+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
7878
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
7979
assertThat(context).hasBean("reactiveIndicatorInitializer");
8080

@@ -93,7 +93,7 @@ void discoveryEnabledDefaultWithSelectiveNamespaces() {
9393
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
9494

9595
// simple from commons and ours
96-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
96+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
9797
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
9898
assertThat(context).hasBean("reactiveIndicatorInitializer");
9999

@@ -112,7 +112,7 @@ void discoveryEnabled() {
112112
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
113113

114114
// simple from commons and ours
115-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
115+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
116116
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
117117
assertThat(context).hasBean("reactiveIndicatorInitializer");
118118

@@ -131,7 +131,7 @@ void discoveryEnabledWithSelectiveNamespaces() {
131131
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
132132

133133
// simple from commons and ours
134-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
134+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
135135
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
136136
assertThat(context).hasBean("reactiveIndicatorInitializer");
137137

@@ -182,7 +182,7 @@ void kubernetesDiscoveryEnabled() {
182182
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
183183

184184
// simple from commons and ours
185-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
185+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
186186
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
187187
assertThat(context).hasBean("reactiveIndicatorInitializer");
188188

@@ -201,7 +201,7 @@ void kubernetesDiscoveryEnabledWithSelectiveNamespaces() {
201201
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
202202

203203
// simple from commons and ours
204-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
204+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
205205
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
206206
assertThat(context).hasBean("reactiveIndicatorInitializer");
207207

@@ -254,7 +254,7 @@ void kubernetesReactiveDiscoveryEnabled() {
254254
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
255255

256256
// simple from commons and ours
257-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
257+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
258258
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
259259
assertThat(context).hasBean("reactiveIndicatorInitializer");
260260

@@ -273,7 +273,7 @@ void kubernetesReactiveDiscoveryEnabledWithSelectiveNamespaces() {
273273
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
274274

275275
// simple from commons and ours
276-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
276+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
277277
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
278278
assertThat(context).hasBean("reactiveIndicatorInitializer");
279279

@@ -327,7 +327,7 @@ void blockingDisabled() {
327327
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
328328

329329
// simple from commons and ours
330-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
330+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
331331
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
332332
assertThat(context).hasBean("reactiveIndicatorInitializer");
333333

@@ -349,7 +349,7 @@ void blockingDisabledWithSelectiveNamespaces() {
349349
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);
350350

351351
// simple from commons and ours
352-
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
352+
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
353353
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
354354
assertThat(context).hasBean("reactiveIndicatorInitializer");
355355

0 commit comments

Comments
 (0)