Drop more overlapping tests (3) #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Jan 19, 2025
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and |
Contributor
Author
There was a problem hiding this comment.
the reason to drop this is this:
- we have a test that uses
spring.cloud.discovery.reactive.enabled=false - we also have a test that does the reverse :
spring.cloud.discovery.reactive.enabled=true
the test that is dropped tests the "default" configuration, meaning it does not have the above property at all, which in turn means it defaults to spring.cloud.discovery.reactive.enabled=false. But such a case is also tested in a plain test, thus not really needed here.
Signed-off-by: wind57 <[email protected]>
wind57
commented
Jan 19, 2025
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * |
Contributor
Author
There was a problem hiding this comment.
we already have a case where we have this exact test, but in an "extended" form. Here we use the filter as:
"spring.cloud.kubernetes.discovery.filter=#root.metadata.namespace matches 'a-uat$'"
in the other one, we use it as :
"spring.cloud.kubernetes.discovery.filter=#root.metadata.namespace matches '^.*uat$'"
so these are overlapping.
wind57
commented
Jan 19, 2025
| /** | ||
| * @author wind57 | ||
| */ | ||
| class Fabric8DiscoveryPodMetadataIT extends Fabric8DiscoveryBase { |
Contributor
Author
There was a problem hiding this comment.
this was nor dropped, but inlined in a different test
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Contributor
Author
|
@ryanjbaxter this one is ready too. Same idea with overlapping tests... Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.