diff --git a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/ConfigurationChangeDetector.java b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/ConfigurationChangeDetector.java index 45ea53c3a1..241e59b6b0 100644 --- a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/ConfigurationChangeDetector.java +++ b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/ConfigurationChangeDetector.java @@ -20,7 +20,6 @@ import org.apache.commons.logging.LogFactory; -import org.springframework.core.env.ConfigurableEnvironment; import org.springframework.core.log.LogAccessor; /** @@ -33,16 +32,9 @@ public abstract class ConfigurationChangeDetector { private static final LogAccessor LOG = new LogAccessor(LogFactory.getLog(ConfigurationChangeDetector.class)); - protected ConfigurableEnvironment environment; - - protected ConfigReloadProperties properties; - protected ConfigurationUpdateStrategy strategy; - public ConfigurationChangeDetector(ConfigurableEnvironment environment, ConfigReloadProperties properties, - ConfigurationUpdateStrategy strategy) { - this.environment = Objects.requireNonNull(environment); - this.properties = Objects.requireNonNull(properties); + public ConfigurationChangeDetector(ConfigurationUpdateStrategy strategy) { this.strategy = Objects.requireNonNull(strategy); } diff --git a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingConfigMapChangeDetector.java b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingConfigMapChangeDetector.java index 602dee2393..e707519ce3 100644 --- a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingConfigMapChangeDetector.java +++ b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingConfigMapChangeDetector.java @@ -50,10 +50,13 @@ public class PollingConfigMapChangeDetector extends ConfigurationChangeDetector private final boolean monitorConfigMaps; + private final AbstractEnvironment environment; + public PollingConfigMapChangeDetector(AbstractEnvironment environment, ConfigReloadProperties properties, ConfigurationUpdateStrategy strategy, Class propertySourceClass, PropertySourceLocator propertySourceLocator, TaskScheduler taskExecutor) { - super(environment, properties, strategy); + super(strategy); + this.environment = environment; this.propertySourceLocator = propertySourceLocator; this.propertySourceClass = propertySourceClass; this.taskExecutor = taskExecutor; diff --git a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingSecretsChangeDetector.java b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingSecretsChangeDetector.java index a540f062fe..c706b15569 100644 --- a/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingSecretsChangeDetector.java +++ b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/reload/PollingSecretsChangeDetector.java @@ -50,10 +50,13 @@ public class PollingSecretsChangeDetector extends ConfigurationChangeDetector { private final boolean monitorSecrets; + private final AbstractEnvironment environment; + public PollingSecretsChangeDetector(AbstractEnvironment environment, ConfigReloadProperties properties, ConfigurationUpdateStrategy strategy, Class propertySourceClass, PropertySourceLocator propertySourceLocator, TaskScheduler taskExecutor) { - super(environment, properties, strategy); + super(strategy); + this.environment = environment; this.propertySourceLocator = propertySourceLocator; this.propertySourceClass = propertySourceClass; this.taskExecutor = taskExecutor; diff --git a/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedConfigMapChangeDetector.java b/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedConfigMapChangeDetector.java index 8c14fd692f..978c8217a0 100644 --- a/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedConfigMapChangeDetector.java +++ b/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedConfigMapChangeDetector.java @@ -65,11 +65,14 @@ public class Fabric8EventBasedConfigMapChangeDetector extends ConfigurationChang private final boolean enableReloadFiltering; + private final AbstractEnvironment environment; + public Fabric8EventBasedConfigMapChangeDetector(AbstractEnvironment environment, ConfigReloadProperties properties, KubernetesClient kubernetesClient, ConfigurationUpdateStrategy strategy, Fabric8ConfigMapPropertySourceLocator fabric8ConfigMapPropertySourceLocator, KubernetesNamespaceProvider namespaceProvider) { - super(environment, properties, strategy); + super(strategy); + this.environment = environment; this.kubernetesClient = kubernetesClient; this.fabric8ConfigMapPropertySourceLocator = fabric8ConfigMapPropertySourceLocator; this.enableReloadFiltering = properties.enableReloadFiltering(); diff --git a/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedSecretsChangeDetector.java b/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedSecretsChangeDetector.java index b29de55de5..a13bb84944 100644 --- a/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedSecretsChangeDetector.java +++ b/spring-cloud-kubernetes-fabric8-config/src/main/java/org/springframework/cloud/kubernetes/fabric8/config/reload/Fabric8EventBasedSecretsChangeDetector.java @@ -65,11 +65,14 @@ public class Fabric8EventBasedSecretsChangeDetector extends ConfigurationChangeD private final boolean enableReloadFiltering; + private final AbstractEnvironment environment; + public Fabric8EventBasedSecretsChangeDetector(AbstractEnvironment environment, ConfigReloadProperties properties, KubernetesClient kubernetesClient, ConfigurationUpdateStrategy strategy, Fabric8SecretsPropertySourceLocator fabric8SecretsPropertySourceLocator, KubernetesNamespaceProvider namespaceProvider) { - super(environment, properties, strategy); + super(strategy); + this.environment = environment; this.kubernetesClient = kubernetesClient; this.fabric8SecretsPropertySourceLocator = fabric8SecretsPropertySourceLocator; this.enableReloadFiltering = properties.enableReloadFiltering();