lower visibility of method ( main ) #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
wind57
commented
Sep 25, 2025
| * @return finds all registered property sources of the given type | ||
| * @deprecated this method will not be public in the next major release. | ||
| */ | ||
| @Deprecated(forRemoval = false) |
Contributor
Author
There was a problem hiding this comment.
lowers the visibility of this method: it is needed because reasoning about the code becomes far easier here.
wind57
commented
Sep 25, 2025
| * Copyright 2013-present the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. |
Contributor
Author
There was a problem hiding this comment.
drop this test that relies on the now non-public above method. tbh, we already cover all these cases in other places anyway
Contributor
Author
|
@ryanjbaxter ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.