clean-up in main after 1757 ( main ) #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
wind57
changed the title
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Contributor
Author
|
The whole idea of this PR, is that a while ago, while fixing an issue, we abused a where We had to do this, otherwise there would be breaking changes. The current PR changes that to : without weird casts and abuses of that It may be vague as an explanation, but its the idea here. If needed, I will go into a lot more details, just let me know |
Contributor
Author
|
@ryanjbaxter this one is ready also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.