Fix some deprecations ( 2 ) #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 22, 2025
| <configuration> | ||
| <source>17</source> | ||
| <target>17</target> | ||
| <compilerArgs> |
There was a problem hiding this comment.
I'd like to leave this on. I sometimes see a deprecation and don't really know where it comes from
wind57
commented
Oct 22, 2025
| Request.Builder builder = new Request.Builder(); | ||
| apiClient.processHeaderParams(Collections.emptyMap(), builder); | ||
| assertThat(builder.url(new URL("http://example.com")).build().headers().get("User-Agent")) | ||
| assertThat(builder.url(URI.create("http://example.com").toURL()).build().headers().get("User-Agent")) |
There was a problem hiding this comment.
java-20 deprecated the constructor we are using here
wind57
commented
Oct 22, 2025
|
|
||
| private static final CoreV1Api CORE_V1_API = Mockito.mock(CoreV1Api.class); | ||
|
|
||
| private static final SharedInformerFactoryStub STUB = new SharedInformerFactoryStub(); |
There was a problem hiding this comment.
STUB does not have a default constructor anymore (to get away from a deprecation), so this code needs a bit of refactor
wind57
commented
Oct 22, 2025
| */ | ||
| final class SharedInformerFactoryStub extends SharedInformerFactory { | ||
|
|
||
| SharedInformerFactoryStub(ApiClient apiClient) { |
There was a problem hiding this comment.
needed to avoid the deprecated constructor
wind57
commented
Oct 22, 2025
| <version>1.4.13</version> | ||
| <configuration> | ||
| <repository>${docker.registry.organization}/${artifactId}</repository> | ||
| <repository>${docker.registry.organization}/${project.artifactId}</repository> |
There was a problem hiding this comment.
${artifactId} is deprecated in favor of ${project.artifactId}
|
@ryanjbaxter remove more deprecations, ready to be looked at. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.