Skip to content

Commit 12468dc

Browse files
committed
Fix checkstyles
1 parent 28e0a69 commit 12468dc

File tree

24 files changed

+60
-38
lines changed

24 files changed

+60
-38
lines changed

binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/JaasLoginModuleConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.cloud.stream.binder.kafka.properties;
1818

1919
import java.util.HashMap;
20+
import java.util.Locale;
2021
import java.util.Map;
2122

2223
import javax.security.auth.login.AppConfigurationEntry;
@@ -55,7 +56,7 @@ public KafkaJaasLoginModuleInitializer.ControlFlag getControlFlag() {
5556
public void setControlFlag(String controlFlag) {
5657
Assert.notNull(controlFlag, "cannot be null");
5758
this.controlFlag = KafkaJaasLoginModuleInitializer.ControlFlag
58-
.valueOf(controlFlag.toUpperCase());
59+
.valueOf(controlFlag.toUpperCase(Locale.ROOT));
5960
}
6061

6162
public Map<String, String> getOptions() {

binders/kafka-binder/spring-cloud-stream-binder-kafka-reactive/src/test/java/org/springframework/cloud/stream/binder/reactorkafka/ReactorKafkaBinderIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.ArrayList;
2121
import java.util.Collections;
2222
import java.util.List;
23+
import java.util.Locale;
2324
import java.util.Map;
2425
import java.util.function.Function;
2526

@@ -193,7 +194,7 @@ Function<Flux<String>, Flux<String>> uppercase() {
193194

194195
@Bean
195196
Function<Flux<ReceiverRecord<byte[], byte[]>>, Flux<String>> lowercase() {
196-
return s -> s.map(rec -> new String(rec.value()).toLowerCase());
197+
return s -> s.map(rec -> new String(rec.value()).toLowerCase(Locale.ROOT));
197198
}
198199

199200
@Bean

binders/kafka-binder/spring-cloud-stream-binder-kafka-reactive/src/test/java/org/springframework/cloud/stream/binder/reactorkafka/ReactorKafkaBinderObservationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.lang.reflect.Type;
2020
import java.time.Duration;
21+
import java.util.Locale;
2122
import java.util.function.Function;
2223
import java.util.stream.Collectors;
2324

@@ -147,7 +148,7 @@ Function<Flux<ReceiverRecord<byte[], byte[]>>, Flux<Message<String>>> receive(Ob
147148
observationRegistry);
148149

149150
return Mono.deferContextual(contextView -> Mono.just(record)
150-
.map(rec -> new String(rec.value()).toLowerCase())
151+
.map(rec -> new String(rec.value()).toLowerCase(Locale.ROOT))
151152
.map(rec -> MessageBuilder.withPayload(rec).setHeader(IntegrationMessageHeaderAccessor.REACTOR_CONTEXT, contextView).build()))
152153
.doOnTerminate(receiverObservation::stop)
153154
.doOnError(receiverObservation::error)

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/main/java/org/springframework/cloud/stream/binder/kafka/streams/AbstractKafkaStreamsBinderProcessor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.util.Arrays;
2020
import java.util.HashMap;
21+
import java.util.Locale;
2122
import java.util.Map;
2223
import java.util.Objects;
2324
import java.util.Optional;
@@ -370,7 +371,7 @@ public Object onSuccess(ConfigurationPropertyName name, Bindable<?> target,
370371
if (!concurrencyExplicitlyProvided[0]) {
371372
concurrencyExplicitlyProvided[0] = name.getLastElement(ConfigurationPropertyName.Form.UNIFORM).equals("concurrency") &&
372373
// name is normalized to contain only uniform elements and thus safe to call toLowerCase here.
373-
ConfigurationPropertyName.of("spring.cloud.stream.bindings." + inboundName.toLowerCase() + ".consumer")
374+
ConfigurationPropertyName.of("spring.cloud.stream.bindings." + inboundName.toLowerCase(Locale.ROOT) + ".consumer")
374375
.isAncestorOf(name);
375376
}
376377
return result;

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/function/KafkaStreamsBinderWordCountBranchesFunctionTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.time.Duration;
2020
import java.util.Arrays;
2121
import java.util.Date;
22+
import java.util.Locale;
2223
import java.util.Map;
2324
import java.util.function.Function;
2425

@@ -190,7 +191,7 @@ public Function<KStream<Object, String>, KStream<?, WordCount>[]> process() {
190191

191192
return input -> {
192193
final Map<String, KStream<Object, WordCount>> stringKStreamMap = input
193-
.flatMapValues(value -> Arrays.asList(value.toLowerCase().split("\\W+")))
194+
.flatMapValues(value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
194195
.groupBy((key, value) -> value)
195196
.windowedBy(TimeWindows.of(Duration.ofSeconds(5)))
196197
.count(Materialized.as("WordCounts-branch"))

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/function/KafkaStreamsBinderWordCountFunctionTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.Collection;
2222
import java.util.Date;
2323
import java.util.List;
24+
import java.util.Locale;
2425
import java.util.Map;
2526
import java.util.Optional;
2627
import java.util.concurrent.CountDownLatch;
@@ -397,7 +398,7 @@ public static class WordCountProcessorApplication {
397398
Function<KStream<Object, String>, KStream<String, WordCount>> process() {
398399

399400
return input -> input
400-
.flatMapValues(value -> Arrays.asList(value.toLowerCase().split("\\W+")))
401+
.flatMapValues(value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
401402
.map((key, value) -> new KeyValue<>(value, value))
402403
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
403404
.windowedBy(TimeWindows.of(Duration.ofMillis(5000)))
@@ -439,7 +440,7 @@ static class OutboundNullApplication {
439440
Function<KStream<Object, String>, KStream<?, WordCount>> process() {
440441
return input -> input
441442
.flatMapValues(
442-
value -> Arrays.asList(value.toLowerCase().split("\\W+")))
443+
value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
443444
.map((key, value) -> new KeyValue<>(value, value))
444445
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
445446
.windowedBy(TimeWindows.ofSizeWithNoGrace(Duration.ofSeconds(5))).count(Materialized.as("foobar-WordCounts"))

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/integration/DlqDestinationResolverTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.time.Duration;
2020
import java.util.Arrays;
21+
import java.util.Locale;
2122
import java.util.Map;
2223
import java.util.function.Function;
2324

@@ -124,7 +125,7 @@ public Function<KStream<Object, String>, KStream<?, String>> process() {
124125

125126
return input -> input
126127
.flatMapValues(
127-
value -> Arrays.asList(value.toLowerCase().split("\\W+")))
128+
value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
128129
.map((key, value) -> new KeyValue<>(value, value))
129130
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
130131
.windowedBy(TimeWindows.of(Duration.ofSeconds(5))).count(Materialized.as("foo-WordCounts-x"))

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/integration/KafkaStreamsBinderMultipleInputTopicsTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.ArrayList;
2020
import java.util.Arrays;
2121
import java.util.List;
22+
import java.util.Locale;
2223
import java.util.Map;
2324
import java.util.function.Function;
2425

@@ -149,7 +150,7 @@ public Function<KStream<Object, String>, KStream<?, WordCount>> process() {
149150

150151
return input -> input
151152
.flatMapValues(
152-
value -> Arrays.asList(value.toLowerCase().split("\\W+")))
153+
value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
153154
.map((key, value) -> new KeyValue<>(value, value))
154155
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
155156
.count(Materialized.as("WordCounts-tKWCWSIAP0")).toStream()

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/integration/KafkaStreamsBinderTombstoneTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.time.Duration;
2020
import java.util.Arrays;
2121
import java.util.Date;
22+
import java.util.Locale;
2223
import java.util.Map;
2324
import java.util.Properties;
2425
import java.util.function.Function;
@@ -173,7 +174,7 @@ static class WordCountProcessorApplication {
173174
public Function<KStream<Object, String>, KStream<String, WordCount>> process() {
174175

175176
return input -> input
176-
.flatMapValues(value -> Arrays.asList(value.toLowerCase().split("\\W+")))
177+
.flatMapValues(value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
177178
.map((key, value) -> new KeyValue<>(value, value))
178179
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
179180
.windowedBy(TimeWindows.of(Duration.ofMillis(5000)))

binders/kafka-binder/spring-cloud-stream-binder-kafka-streams/src/test/java/org/springframework/cloud/stream/binder/kafka/streams/integration/KafkaStreamsNativeEncodingDecodingDisabledTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.nio.charset.StandardCharsets;
2020
import java.time.Duration;
2121
import java.util.Arrays;
22+
import java.util.Locale;
2223
import java.util.Map;
2324
import java.util.function.Function;
2425

@@ -153,7 +154,7 @@ public Function<KStream<Object, String>, KStream<?, String>> process() {
153154

154155
return input -> input
155156
.flatMapValues(
156-
value -> Arrays.asList(value.toLowerCase().split("\\W+")))
157+
value -> Arrays.asList(value.toLowerCase(Locale.ROOT).split("\\W+")))
157158
.map((key, value) -> new KeyValue<>(value, value))
158159
.groupByKey(Grouped.with(Serdes.String(), Serdes.String()))
159160
.windowedBy(TimeWindows.of(Duration.ofSeconds(5))).count(Materialized.as("foo-WordCounts-x"))

0 commit comments

Comments
 (0)