Skip to content

Commit 36b1328

Browse files
committed
Fix Rabbit boot 4.0 migration issues
1 parent e99bd24 commit 36b1328

File tree

4 files changed

+18
-11
lines changed

4 files changed

+18
-11
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
org.springframework.boot.env.EnvironmentPostProcessor=\
1+
org.springframework.boot.EnvironmentPostProcessor=\
22
org.springframework.cloud.stream.binder.kafka.streams.KafkaStreamsBinderEnvironmentPostProcessor

binders/rabbit-binder/spring-cloud-stream-binder-rabbit/pom.xml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,16 @@
1414
</parent>
1515

1616
<dependencies>
17-
<!-- <dependency>
18-
<groupId>org.springframework.cloud</groupId>
19-
<artifactId>spring-cloud-function-deployer</artifactId>
20-
<version>${spring-cloud-function.version}</version>
21-
<optional>true</optional>
22-
</dependency> -->
2317
<dependency>
2418
<groupId>org.springframework.cloud</groupId>
2519
<artifactId>spring-cloud-stream-binder-rabbit-core</artifactId>
2620
<version>${project.version}</version>
2721
</dependency>
22+
<dependency>
23+
<groupId>org.springframework.cloud</groupId>
24+
<artifactId>spring-cloud-function-context</artifactId>
25+
<version>${project.version}</version>
26+
</dependency>
2827
<dependency>
2928
<groupId>org.springframework.boot</groupId>
3029
<artifactId>spring-boot-amqp</artifactId>
@@ -53,6 +52,14 @@
5352
<artifactId>spring-boot-autoconfigure</artifactId>
5453
<optional>true</optional>
5554
</dependency>
55+
<dependency>
56+
<groupId>org.springframework.boot</groupId>
57+
<artifactId>spring-boot-micrometer-tracing-test</artifactId>
58+
<scope>test</scope>
59+
</dependency>
60+
61+
62+
5663
<dependency>
5764
<groupId>org.springframework.cloud</groupId>
5865
<artifactId>spring-cloud-connectors-core</artifactId>

binders/rabbit-binder/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import com.rabbitmq.client.Channel;
3535
import com.rabbitmq.client.Envelope;
3636
import io.micrometer.observation.ObservationRegistry;
37-
import jakarta.validation.constraints.NotNull;
3837

3938
import org.springframework.amqp.AmqpRejectAndDontRequeueException;
4039
import org.springframework.amqp.ImmediateAcknowledgeAmqpException;
@@ -802,7 +801,7 @@ else if (amqpMessages == null) {
802801
}
803802
}
804803

805-
@NotNull
804+
//@NotNull
806805
private MessageProperties adjustMessagePropertiesHeader(Throwable cause, String stackTraceAsString, Message amqpMessage) {
807806
MessageProperties messageProperties = amqpMessage
808807
.getMessageProperties();

binders/rabbit-binder/spring-cloud-stream-binder-rabbit/src/test/java/org/springframework/cloud/stream/binder/rabbit/integration/RabbitMultiBinderObservationTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
import io.micrometer.tracing.brave.bridge.BraveFinishedSpan;
2929
import io.micrometer.tracing.test.simple.SpansAssert;
3030
import org.junit.jupiter.api.Test;
31+
import org.springframework.boot.micrometer.tracing.test.autoconfigure.AutoConfigureTracing;
3132
import org.testcontainers.containers.RabbitMQContainer;
3233

3334
import org.springframework.beans.factory.annotation.Autowired;
3435
import org.springframework.boot.SpringBootConfiguration;
3536
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
36-
import org.springframework.boot.test.autoconfigure.actuate.observability.AutoConfigureObservability;
3737
import org.springframework.boot.test.context.SpringBootTest;
3838
import org.springframework.cloud.stream.binder.rabbit.RabbitTestContainer;
3939
import org.springframework.cloud.stream.function.StreamBridge;
@@ -53,7 +53,8 @@
5353
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE,
5454
args = "--spring.config.location=classpath:/rabbit-multi-binder-observation.yml")
5555
@DirtiesContext
56-
@AutoConfigureObservability
56+
//@AutoConfigureMetric
57+
@AutoConfigureTracing
5758
public class RabbitMultiBinderObservationTests {
5859

5960
private static final TestSpanHandler SPANS = new TestSpanHandler();

0 commit comments

Comments
 (0)