Skip to content

Commit 756d97d

Browse files
committed
Need to Autoconfigure Observations
1 parent cc247c1 commit 756d97d

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

spring-cloud-task-core/src/test/java/org/springframework/cloud/task/configuration/observation/ObservationIntegrationTests.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.List;
2020
import java.util.stream.Collectors;
2121

22-
import brave.handler.SpanHandler;
2322
import brave.sampler.Sampler;
2423
import brave.test.TestSpanHandler;
2524
import io.micrometer.common.KeyValues;
@@ -32,9 +31,6 @@
3231
import org.junit.jupiter.api.Test;
3332
import org.slf4j.Logger;
3433
import org.slf4j.LoggerFactory;
35-
import zipkin2.Span;
36-
import zipkin2.reporter.Reporter;
37-
import zipkin2.reporter.brave.ZipkinSpanHandler;
3834

3935
import org.springframework.beans.factory.annotation.Autowired;
4036
import org.springframework.boot.ApplicationRunner;
@@ -46,12 +42,14 @@
4642
import org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration;
4743
import org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinAutoConfiguration;
4844
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
45+
import org.springframework.boot.test.autoconfigure.actuate.observability.AutoConfigureObservability;
4946
import org.springframework.boot.test.context.SpringBootTest;
5047
import org.springframework.cloud.task.configuration.EnableTask;
5148
import org.springframework.cloud.task.configuration.SimpleTaskAutoConfiguration;
5249
import org.springframework.context.annotation.Bean;
5350
import org.springframework.context.annotation.Configuration;
5451

52+
@AutoConfigureObservability
5553
@SpringBootTest(classes = ObservationIntegrationTests.Config.class)
5654
class ObservationIntegrationTests {
5755

@@ -91,11 +89,6 @@ TestSpanHandler testSpanHandler() {
9189
return new TestSpanHandler();
9290
}
9391

94-
@Bean
95-
SpanHandler zipkinSpanHandler(Reporter<Span> spanReporter) {
96-
return ZipkinSpanHandler.newBuilder(spanReporter).build();
97-
}
98-
9992
@Bean
10093
Sampler sampler() {
10194
return Sampler.ALWAYS_SAMPLE;

0 commit comments

Comments
 (0)