Skip to content

Commit 80f39be

Browse files
committed
Removed cfenv from dependencies
Updated tests that used it. resolves #681
1 parent 59c9adf commit 80f39be

File tree

3 files changed

+38
-16
lines changed

3 files changed

+38
-16
lines changed

spring-cloud-task-core/pom.xml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
<packaging>jar</packaging>
1414
<name>Spring Cloud Task Core</name>
1515
<description>Spring Cloud Task</description>
16+
<properties>
17+
<jmock-version>1.49</jmock-version>
18+
</properties>
1619

1720
<dependencies>
1821
<dependency>
@@ -109,11 +112,6 @@
109112
<groupId>io.micrometer</groupId>
110113
<artifactId>micrometer-core</artifactId>
111114
</dependency>
112-
<dependency>
113-
<groupId>io.pivotal.cfenv</groupId>
114-
<artifactId>java-cfenv-test-support</artifactId>
115-
<scope>test</scope>
116-
</dependency>
117115
<dependency>
118116
<groupId>org.junit.jupiter</groupId>
119117
<artifactId>junit-jupiter-params</artifactId>
@@ -124,6 +122,12 @@
124122
<artifactId>junit-jupiter-engine</artifactId>
125123
<scope>test</scope>
126124
</dependency>
125+
<dependency>
126+
<groupId>org.jmockit</groupId>
127+
<artifactId>jmockit</artifactId>
128+
<version>${jmock-version}</version>
129+
<scope>test</scope>
130+
</dependency>
127131
</dependencies>
128132

129133
</project>

spring-cloud-task-core/src/test/java/org/springframework/cloud/task/micrometer/AbstractMicrometerTest.java

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,16 @@
1818

1919
import java.io.IOException;
2020
import java.nio.charset.Charset;
21+
import java.util.HashMap;
22+
import java.util.Map;
2123

2224
import io.micrometer.core.instrument.Clock;
2325
import io.micrometer.core.instrument.Meter;
2426
import io.micrometer.core.instrument.Metrics;
2527
import io.micrometer.core.instrument.simple.SimpleConfig;
2628
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
27-
import io.pivotal.cfenv.test.CfEnvTestUtils;
29+
import mockit.Mock;
30+
import mockit.MockUp;
2831
import org.junit.jupiter.api.AfterEach;
2932
import org.junit.jupiter.api.BeforeAll;
3033
import org.junit.jupiter.api.BeforeEach;
@@ -80,7 +83,31 @@ public static void setup() throws IOException {
8083
String serviceJson = StreamUtils.copyToString(new DefaultResourceLoader()
8184
.getResource("classpath:/micrometer/pcf-scs-info.json").getInputStream(),
8285
Charset.forName("UTF-8"));
83-
CfEnvTestUtils.mockVcapServicesFromString(serviceJson);
86+
mockVcapServicesFromString(serviceJson);
87+
}
88+
89+
public static MockUp<?> mockVcapServicesFromString(String serviceJson) {
90+
final Map<String, String> env = System.getenv();
91+
return new MockUp<System>() {
92+
@Mock
93+
public String getenv(String name) {
94+
if (name.equalsIgnoreCase("VCAP_SERVICES")) {
95+
return serviceJson;
96+
}
97+
else {
98+
return name.equalsIgnoreCase("VCAP_APPLICATION")
99+
? "{\"instance_id\":\"123\"}" : (String) env.get(name);
100+
}
101+
}
102+
103+
@Mock
104+
public Map getenv() {
105+
Map<String, String> finalMap = new HashMap();
106+
finalMap.putAll(env);
107+
finalMap.put("VCAP_SERVICES", serviceJson);
108+
return finalMap;
109+
}
110+
};
84111
}
85112

86113
@SpringBootApplication

spring-cloud-task-dependencies/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
<relativePath />
1515
</parent>
1616

17-
<properties>
18-
<java-cfenv-boot.version>2.1.0.RELEASE</java-cfenv-boot.version>
19-
</properties>
20-
2117
<dependencyManagement>
2218
<dependencies>
2319
<dependency>
@@ -40,11 +36,6 @@
4036
<artifactId>spring-cloud-task-stream</artifactId>
4137
<version>2.3.0-SNAPSHOT</version>
4238
</dependency>
43-
<dependency>
44-
<groupId>io.pivotal.cfenv</groupId>
45-
<artifactId>java-cfenv-test-support</artifactId>
46-
<version>${java-cfenv-boot.version}</version>
47-
</dependency>
4839
</dependencies>
4940
</dependencyManagement>
5041

0 commit comments

Comments
 (0)