Skip to content

Commit 8f1b318

Browse files
lianejcppwfs
authored andcommitted
Fixed the bug where spring.cloud.task.transaction-manager was not working
Added additional for the default case
1 parent a2145b2 commit 8f1b318

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

spring-cloud-task-core/src/main/java/org/springframework/cloud/task/configuration/NoTransactionManagerProperty.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
class NoTransactionManagerProperty extends NoneNestedConditions {
3030

3131
NoTransactionManagerProperty() {
32-
super(ConfigurationPhase.PARSE_CONFIGURATION);
32+
super(ConfigurationPhase.REGISTER_BEAN);
3333
}
3434

3535
@ConditionalOnProperty(prefix = "spring.cloud.task", name = "transaction-manager")

spring-cloud-task-core/src/test/java/org/springframework/cloud/task/SimpleTaskAutoConfigurationTests.java

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import org.springframework.aop.framework.AopProxyUtils;
2525
import org.springframework.aop.scope.ScopedProxyUtils;
26+
import org.springframework.batch.support.transaction.ResourcelessTransactionManager;
2627
import org.springframework.beans.factory.BeanCreationException;
2728
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
2829
import org.springframework.beans.factory.annotation.Autowired;
@@ -47,6 +48,7 @@
4748
import org.springframework.context.ConfigurableApplicationContext;
4849
import org.springframework.context.annotation.Bean;
4950
import org.springframework.context.annotation.Configuration;
51+
import org.springframework.transaction.PlatformTransactionManager;
5052

5153
import static org.assertj.core.api.Assertions.assertThat;
5254
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@@ -173,6 +175,32 @@ public void testMultipleDataSources() {
173175

174176
}
175177

178+
@Test
179+
void testSpecifyTransactionManager() {
180+
ApplicationContextRunner applicationContextRunner = new ApplicationContextRunner()
181+
.withConfiguration(AutoConfigurations.of(PropertyPlaceholderAutoConfiguration.class,
182+
SimpleTaskAutoConfiguration.class, SingleTaskConfiguration.class))
183+
.withBean("transactionManager", ResourcelessTransactionManager.class)
184+
.withPropertyValues("spring.cloud.task.transaction-manager=transactionManager");
185+
applicationContextRunner.run((context) -> {
186+
assertThat(context.getBeanNamesForType(PlatformTransactionManager.class)).hasSize(1)
187+
.contains("transactionManager")
188+
.doesNotContain("springCloudTaskTransactionManager");
189+
});
190+
}
191+
192+
@Test
193+
void testDefaultTransactionManager() {
194+
ApplicationContextRunner applicationContextRunner = new ApplicationContextRunner()
195+
.withConfiguration(AutoConfigurations.of(PropertyPlaceholderAutoConfiguration.class,
196+
SimpleTaskAutoConfiguration.class, SingleTaskConfiguration.class));
197+
applicationContextRunner.run((context) -> {
198+
assertThat(context.getBeanNamesForType(PlatformTransactionManager.class)).hasSize(1)
199+
.contains("springCloudTaskTransactionManager")
200+
.doesNotContain("transactionManager");
201+
});
202+
}
203+
176204
public void verifyExceptionThrownDefaultExecutable(Class classToCheck,
177205
ApplicationContextRunner applicationContextRunner) {
178206
Executable executable = () -> {

0 commit comments

Comments
 (0)