Skip to content

Commit 93156fd

Browse files
mminellacppwfs
authored andcommitted
Added documentation for the Single Step Batch Job Starter
This commit does two things: 1. Adds documentation to the reference documentation for the single step batch job starter. 2. It standardizes the naming of the properties across the various readers/writers the autoconfiguration provides. Polished docs on merge
1 parent 292b89b commit 93156fd

19 files changed

+677
-143
lines changed

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/flatfile/FlatFileItemReaderAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public FlatFileItemReaderAutoConfiguration(FlatFileItemReaderProperties properti
7171

7272
@Bean
7373
@ConditionalOnMissingBean
74-
@ConditionalOnProperty(prefix = "spring.batch.job.flatfilereader", name = "name")
74+
@ConditionalOnProperty(prefix = "spring.batch.job.flatfileitemreader", name = "name")
7575
public FlatFileItemReader<Map<String, Object>> itemReader() {
7676
FlatFileItemReaderBuilder<Map<String, Object>> mapFlatFileItemReaderBuilder = new FlatFileItemReaderBuilder<Map<String, Object>>()
7777
.name(this.properties.getName()).resource(this.properties.getResource())

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/flatfile/FlatFileItemReaderProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* @author Michael Minella
3232
* @since 2.3
3333
*/
34-
@ConfigurationProperties(prefix = "spring.batch.job.flatfilereader")
34+
@ConfigurationProperties(prefix = "spring.batch.job.flatfileitemreader")
3535
public class FlatFileItemReaderProperties {
3636

3737
private boolean saveState = true;

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/flatfile/FlatFileItemWriterAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public FlatFileItemWriterAutoConfiguration(FlatFileItemWriterProperties properti
6666

6767
@Bean
6868
@ConditionalOnMissingBean
69-
@ConditionalOnProperty(prefix = "spring.batch.job.flatfilewriter", name = "name")
69+
@ConditionalOnProperty(prefix = "spring.batch.job.flatfileitemwriter", name = "name")
7070
public FlatFileItemWriter<Map<String, Object>> itemWriter() {
7171

7272
if (this.properties.isDelimited() && this.properties.isFormatted()) {

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/flatfile/FlatFileItemWriterProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* @author Michael Minella
2929
* @since 2.3
3030
*/
31-
@ConfigurationProperties(prefix = "spring.batch.job.flatfilewriter")
31+
@ConfigurationProperties(prefix = "spring.batch.job.flatfileitemwriter")
3232
public class FlatFileItemWriterProperties {
3333

3434
private Resource resource;
Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020

2121
import javax.sql.DataSource;
2222

23-
import org.springframework.batch.item.ItemWriter;
2423
import org.springframework.batch.item.database.ItemPreparedStatementSetter;
2524
import org.springframework.batch.item.database.ItemSqlParameterSourceProvider;
25+
import org.springframework.batch.item.database.JdbcBatchItemWriter;
2626
import org.springframework.batch.item.database.builder.JdbcBatchItemWriterBuilder;
2727
import org.springframework.beans.factory.annotation.Autowired;
2828
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
@@ -41,30 +41,30 @@
4141
* @since 2.3
4242
*/
4343
@Configuration
44-
@EnableConfigurationProperties(JdbcItemWriterProperties.class)
44+
@EnableConfigurationProperties(JdbcBatchItemWriterProperties.class)
4545
@AutoConfigureAfter(BatchAutoConfiguration.class)
46-
public class JdbcItemWriterAutoConfiguration {
46+
public class JdbcBatchItemWriterAutoConfiguration {
4747

4848
@Autowired(required = false)
4949
private ItemPreparedStatementSetter itemPreparedStatementSetter;
5050

5151
@Autowired(required = false)
5252
private ItemSqlParameterSourceProvider itemSqlParameterSourceProvider;
5353

54-
private JdbcItemWriterProperties properties;
54+
private JdbcBatchItemWriterProperties properties;
5555

5656
private DataSource dataSource;
5757

58-
public JdbcItemWriterAutoConfiguration(DataSource dataSource,
59-
JdbcItemWriterProperties properties) {
58+
public JdbcBatchItemWriterAutoConfiguration(DataSource dataSource,
59+
JdbcBatchItemWriterProperties properties) {
6060
this.dataSource = dataSource;
6161
this.properties = properties;
6262
}
6363

6464
@Bean
6565
@ConditionalOnMissingBean
66-
@ConditionalOnProperty(prefix = "spring.batch.job.jdbcwriter", name = "name")
67-
public ItemWriter<Map<String, Object>> itemWriter() {
66+
@ConditionalOnProperty(prefix = "spring.batch.job.jdbcbatchitemwriter", name = "name")
67+
public JdbcBatchItemWriter<Map<String, Object>> itemWriter() {
6868

6969
JdbcBatchItemWriterBuilder<Map<String, Object>> jdbcBatchItemWriterBuilder = new JdbcBatchItemWriterBuilder<Map<String, Object>>()
7070
.dataSource(this.dataSource).sql(this.properties.getSql());
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
import org.springframework.boot.context.properties.ConfigurationProperties;
2020

2121
/**
22-
* Properties to configure a {@code JdbcItemWriter}.
22+
* Properties to configure a {@code JdbcBatchItemWriter}.
2323
*
2424
* @author Glenn Renfro
2525
* @since 2.3
2626
*/
27-
@ConfigurationProperties(prefix = "spring.batch.job.jdbcwriter")
28-
public class JdbcItemWriterProperties {
27+
@ConfigurationProperties(prefix = "spring.batch.job.jdbcbatchitemwriter")
28+
public class JdbcBatchItemWriterProperties {
2929

3030
private String name;
3131

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/jdbc/JdbcCursorItemReaderAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
@Configuration
4444
@EnableConfigurationProperties(JdbcCursorItemReaderProperties.class)
4545
@AutoConfigureAfter(BatchAutoConfiguration.class)
46-
@ConditionalOnProperty(prefix = "spring.batch.job.jdbccursorreader", name = "name")
46+
@ConditionalOnProperty(prefix = "spring.batch.job.jdbccursoritemreader", name = "name")
4747
public class JdbcCursorItemReaderAutoConfiguration {
4848

4949
private final JdbcCursorItemReaderProperties properties;

spring-cloud-starter-single-step-batch-job/src/main/java/org/springframework/cloud/task/batch/autoconfigure/jdbc/JdbcCursorItemReaderProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* @author Michael Minella
2323
* @since 2.3
2424
*/
25-
@ConfigurationProperties(prefix = "spring.batch.job.jdbccursorreader")
25+
@ConfigurationProperties(prefix = "spring.batch.job.jdbccursoritemreader")
2626
public class JdbcCursorItemReaderProperties {
2727

2828
private boolean saveState = true;

spring-cloud-starter-single-step-batch-job/src/main/resources/META-INF/spring.factories

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ org.springframework.boot.autoconfigure.EnableAutoConfiguration=org.springframewo
22
org.springframework.cloud.task.batch.autoconfigure.RangeConverter,\
33
org.springframework.cloud.task.batch.autoconfigure.SingleStepJobAutoConfiguration,\
44
org.springframework.cloud.task.batch.autoconfigure.flatfile.FlatFileItemWriterAutoConfiguration, \
5-
org.springframework.cloud.task.batch.autoconfigure.jdbc.JdbcItemWriterAutoConfiguration, \
5+
org.springframework.cloud.task.batch.autoconfigure.jdbc.JdbcBatchItemWriterAutoConfiguration, \
66
org.springframework.cloud.task.batch.autoconfigure.jdbc.JdbcCursorItemReaderAutoConfiguration, \
77
org.springframework.cloud.task.batch.autoconfigure.rabbit.AmqpItemReaderAutoConfiguration, \
88
org.springframework.cloud.task.batch.autoconfigure.rabbit.AmqpItemWriterAutoConfiguration, \

spring-cloud-starter-single-step-batch-job/src/test/java/org/springframework/cloud/task/batch/autoconfigure/flatfile/FlatFileItemReaderAutoConfigurationTests.java

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -85,21 +85,21 @@ public void testFullDelimitedConfiguration() {
8585
FlatFileItemReaderAutoConfiguration.class))
8686
.withPropertyValues("spring.batch.job.jobName=job",
8787
"spring.batch.job.stepName=step1", "spring.batch.job.chunkSize=5",
88-
"spring.batch.job.flatfilereader.savestate=true",
89-
"spring.batch.job.flatfilereader.name=fullDelimitedConfiguration",
90-
"spring.batch.job.flatfilereader.maxItemCount=5",
91-
"spring.batch.job.flatfilereader.currentItemCount=2",
92-
"spring.batch.job.flatfilereader.comments=#,$",
93-
"spring.batch.job.flatfilereader.resource=/testUTF16.csv",
94-
"spring.batch.job.flatfilereader.strict=true",
95-
"spring.batch.job.flatfilereader.encoding=UTF-16",
96-
"spring.batch.job.flatfilereader.linesToSkip=1",
97-
"spring.batch.job.flatfilereader.delimited=true",
98-
"spring.batch.job.flatfilereader.delimiter=@",
99-
"spring.batch.job.flatfilereader.quoteCharacter=%",
100-
"spring.batch.job.flatfilereader.includedFields=1,3,5",
101-
"spring.batch.job.flatfilereader.names=foo,bar,baz",
102-
"spring.batch.job.flatfilereader.parsingStrict=false");
88+
"spring.batch.job.flatfileitemreader.savestate=true",
89+
"spring.batch.job.flatfileitemreader.name=fullDelimitedConfiguration",
90+
"spring.batch.job.flatfileitemreader.maxItemCount=5",
91+
"spring.batch.job.flatfileitemreader.currentItemCount=2",
92+
"spring.batch.job.flatfileitemreader.comments=#,$",
93+
"spring.batch.job.flatfileitemreader.resource=/testUTF16.csv",
94+
"spring.batch.job.flatfileitemreader.strict=true",
95+
"spring.batch.job.flatfileitemreader.encoding=UTF-16",
96+
"spring.batch.job.flatfileitemreader.linesToSkip=1",
97+
"spring.batch.job.flatfileitemreader.delimited=true",
98+
"spring.batch.job.flatfileitemreader.delimiter=@",
99+
"spring.batch.job.flatfileitemreader.quoteCharacter=%",
100+
"spring.batch.job.flatfileitemreader.includedFields=1,3,5",
101+
"spring.batch.job.flatfileitemreader.names=foo,bar,baz",
102+
"spring.batch.job.flatfileitemreader.parsingStrict=false");
103103

104104
applicationContextRunner.run((context) -> {
105105
JobLauncher jobLauncher = context.getBean(JobLauncher.class);
@@ -142,15 +142,15 @@ public void testFixedWidthConfiguration() {
142142
FlatFileItemReaderAutoConfiguration.class, RangeConverter.class))
143143
.withPropertyValues("spring.batch.job.jobName=job",
144144
"spring.batch.job.stepName=step1", "spring.batch.job.chunkSize=5",
145-
"spring.batch.job.flatfilereader.savestate=true",
146-
"spring.batch.job.flatfilereader.name=fixedWidthConfiguration",
147-
"spring.batch.job.flatfilereader.comments=#,$",
148-
"spring.batch.job.flatfilereader.resource=/test.txt",
149-
"spring.batch.job.flatfilereader.strict=true",
150-
"spring.batch.job.flatfilereader.fixedLength=true",
151-
"spring.batch.job.flatfilereader.ranges=3-4,7-8,11",
152-
"spring.batch.job.flatfilereader.names=foo,bar,baz",
153-
"spring.batch.job.flatfilereader.parsingStrict=false");
145+
"spring.batch.job.flatfileitemreader.savestate=true",
146+
"spring.batch.job.flatfileitemreader.name=fixedWidthConfiguration",
147+
"spring.batch.job.flatfileitemreader.comments=#,$",
148+
"spring.batch.job.flatfileitemreader.resource=/test.txt",
149+
"spring.batch.job.flatfileitemreader.strict=true",
150+
"spring.batch.job.flatfileitemreader.fixedLength=true",
151+
"spring.batch.job.flatfileitemreader.ranges=3-4,7-8,11",
152+
"spring.batch.job.flatfileitemreader.names=foo,bar,baz",
153+
"spring.batch.job.flatfileitemreader.parsingStrict=false");
154154

155155
applicationContextRunner.run((context) -> {
156156
JobLauncher jobLauncher = context.getBean(JobLauncher.class);
@@ -202,9 +202,9 @@ public void testCustomLineMapper() {
202202
FlatFileItemReaderAutoConfiguration.class))
203203
.withPropertyValues("spring.batch.job.jobName=job",
204204
"spring.batch.job.stepName=step1", "spring.batch.job.chunkSize=5",
205-
"spring.batch.job.flatfilereader.name=fixedWidthConfiguration",
206-
"spring.batch.job.flatfilereader.resource=/test.txt",
207-
"spring.batch.job.flatfilereader.strict=true");
205+
"spring.batch.job.flatfileitemreader.name=fixedWidthConfiguration",
206+
"spring.batch.job.flatfileitemreader.resource=/test.txt",
207+
"spring.batch.job.flatfileitemreader.strict=true");
208208

209209
applicationContextRunner.run((context) -> {
210210
JobLauncher jobLauncher = context.getBean(JobLauncher.class);
@@ -242,13 +242,13 @@ public void testCustomRecordSeparatorAndSkippedLines() {
242242
FlatFileItemReaderAutoConfiguration.class, RangeConverter.class))
243243
.withPropertyValues("spring.batch.job.jobName=job",
244244
"spring.batch.job.stepName=step1", "spring.batch.job.chunkSize=5",
245-
"spring.batch.job.flatfilereader.name=fixedWidthConfiguration",
246-
"spring.batch.job.flatfilereader.resource=/test.txt",
247-
"spring.batch.job.flatfilereader.linesToSkip=2",
248-
"spring.batch.job.flatfilereader.fixedLength=true",
249-
"spring.batch.job.flatfilereader.ranges=3-4,7-8,11",
250-
"spring.batch.job.flatfilereader.names=foo,bar,baz",
251-
"spring.batch.job.flatfilereader.strict=true");
245+
"spring.batch.job.flatfileitemreader.name=fixedWidthConfiguration",
246+
"spring.batch.job.flatfileitemreader.resource=/test.txt",
247+
"spring.batch.job.flatfileitemreader.linesToSkip=2",
248+
"spring.batch.job.flatfileitemreader.fixedLength=true",
249+
"spring.batch.job.flatfileitemreader.ranges=3-4,7-8,11",
250+
"spring.batch.job.flatfileitemreader.names=foo,bar,baz",
251+
"spring.batch.job.flatfileitemreader.strict=true");
252252

253253
applicationContextRunner.run((context) -> {
254254
JobLauncher jobLauncher = context.getBean(JobLauncher.class);
@@ -287,10 +287,10 @@ public void testCustomMapping() {
287287
FlatFileItemReaderAutoConfiguration.class, RangeConverter.class))
288288
.withPropertyValues("spring.batch.job.jobName=job",
289289
"spring.batch.job.stepName=step1", "spring.batch.job.chunkSize=5",
290-
"spring.batch.job.flatfilereader.name=fixedWidthConfiguration",
291-
"spring.batch.job.flatfilereader.resource=/test.txt",
292-
"spring.batch.job.flatfilereader.maxItemCount=1",
293-
"spring.batch.job.flatfilereader.strict=true");
290+
"spring.batch.job.flatfileitemreader.name=fixedWidthConfiguration",
291+
"spring.batch.job.flatfileitemreader.resource=/test.txt",
292+
"spring.batch.job.flatfileitemreader.maxItemCount=1",
293+
"spring.batch.job.flatfileitemreader.strict=true");
294294

295295
applicationContextRunner.run((context) -> {
296296
JobLauncher jobLauncher = context.getBean(JobLauncher.class);

0 commit comments

Comments
 (0)