Skip to content

Commit 5d71996

Browse files
committed
Change order of fetch/pull and tagging in the spring-finalize-release.yml
* Add `--no-tags` to the `git fetch` to avoid pulling remote tags
1 parent d22e8fd commit 5d71996

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/spring-finalize-release.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,12 @@ jobs:
4444
fi
4545
git config --global user.name 'Spring Builds'
4646
git config --global user.email '[email protected]'
47+
48+
git fetch origin --no-tags
49+
git pull origin ${{ github.ref }}
50+
4751
git commit -a -m "[artifactory-release] Release version ${{ inputs.milestone }}"
4852
git tag "v${{ inputs.milestone }}"
49-
git push --tags origin
5053
5154
NEXT_VERSION="${{ inputs.milestone }}"
5255
@@ -62,9 +65,6 @@ jobs:
6265
6366
NEXT_VERSION=${NEXT_VERSION}-SNAPSHOT
6467
65-
git fetch origin
66-
git pull origin ${{ github.ref }}
67-
6868
if test -f pom.xml
6969
then
7070
mvn versions:set -DnewVersion=$NEXT_VERSION -DgenerateBackupPoms=false -DprocessAllModules=true -B -ntp
@@ -74,6 +74,7 @@ jobs:
7474
7575
git commit -a -m "[artifactory-release] Next development version"
7676
git push origin
77+
git push --tags origin
7778
7879
echo nextVersion=$NEXT_VERSION >> $GITHUB_OUTPUT
7980

0 commit comments

Comments
 (0)