Improve MavenClasspathEntry Error Handling

Closes gh-66

Author: rwinch

spring-boot-testjars-maven/src/main/java/org/springframework/experimental/boot/server/exec/MavenClasspathEntry.java

@@ -39,6 +39,7 @@
 import org.eclipse.aether.impl.DefaultServiceLocator;
 import org.eclipse.aether.repository.LocalRepository;
 import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.resolution.ArtifactDescriptorPolicy;
 import org.eclipse.aether.resolution.ArtifactResult;
 import org.eclipse.aether.resolution.DependencyRequest;
 import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;
@@ -47,6 +48,7 @@
 import org.eclipse.aether.transport.http.HttpTransporterFactory;
 import org.eclipse.aether.util.artifact.JavaScopes;
 import org.eclipse.aether.util.filter.DependencyFilterUtils;
+import org.eclipse.aether.util.repository.SimpleArtifactDescriptorPolicy;
 
 import org.springframework.boot.SpringBootVersion;
 
@@ -144,9 +146,9 @@ public List<String> resolve() {
 			}
 		}
 		catch (Exception ex) {
-			if (this.logger.isErrorEnabled()) {
-				this.logger.error("Error resolving artifact " + this.coords, ex);
-			}
+			String message = "Error resolving artifact " + this.coords;
+			this.logger.debug(message, ex);
+			throw new RuntimeException(message, ex);
 		}
 		return result;
 	}
@@ -188,6 +190,8 @@ private static DefaultRepositorySystemSession newRepositorySystemSession(Reposit
 		session.setSystemProperties(sysProps);
 		session.setConfigProperties(sysProps);
 
+		SimpleArtifactDescriptorPolicy policy = new SimpleArtifactDescriptorPolicy(ArtifactDescriptorPolicy.STRICT);
+		session.setArtifactDescriptorPolicy(policy);
 
 		// uncomment to generate dirty trees
 		// session.setDependencyGraphTransformer( null );

spring-boot-testjars/src/main/java/org/springframework/experimental/boot/server/exec/CommonsExecWebServer.java

@@ -24,6 +24,8 @@
 import org.apache.commons.exec.DefaultExecutor;
 import org.apache.commons.exec.ExecuteException;
 import org.apache.commons.exec.ExecuteResultHandler;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 import org.springframework.beans.factory.DisposableBean;
 import org.springframework.beans.factory.InitializingBean;
@@ -41,6 +43,8 @@
  */
 public final class CommonsExecWebServer implements WebServer, InitializingBean, DisposableBean, AutoCloseable {
 
+	private final Log logger = LogFactory.getLog(getClass());
+
 	private final CommandLine commandLine;
 
 	private final File applicationPortFile;
@@ -78,6 +82,9 @@ public void start() {
 		DefaultExecutor executor = new DefaultExecutor();
 		executor.setProcessDestroyer(this.processDestroyerBean);
 		try {
+			if (this.logger.isDebugEnabled()) {
+				this.logger.debug("Executing command: " + this.commandLine);
+			}
 			executor.execute(this.commandLine, null, this.handler);
 		}
 		catch (Exception ex) {

spring-boot-testjars/src/main/java/org/springframework/experimental/boot/server/exec/ResourceClasspathEntry.java

@@ -65,7 +65,8 @@ public List<String> resolve() {
 				}
 			}
 			catch (IOException ex) {
-				throw new RuntimeException(ex);
+				throw new RuntimeException("Failed to copy existingResourceName '" + this.existingResourceName
+						+ "' to '" + this.classpathResourceName + "'", ex);
 			}
 		}
 		return Arrays.asList(this.classpath.toFile().getAbsolutePath());

spring-boot-testjars/src/main/java/org/springframework/experimental/boot/server/exec/ScanningClasspathEntry.java

@@ -24,6 +24,9 @@
 import java.util.function.Function;
 import java.util.regex.Pattern;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import org.springframework.core.io.ClassPathResource;
 import org.springframework.core.io.FileSystemResource;
 import org.springframework.core.io.Resource;
@@ -37,6 +40,8 @@
  */
 class ScanningClasspathEntry implements ClasspathEntry {
 
+	private Log logger = LogFactory.getLog(getClass());
+
 	private final String resourcePattern;
 
 	private final Function<String, String> renameResource;
@@ -80,6 +85,9 @@ private Path createClasspath() {
 				if (!path.endsWith("/") && resource.isReadable()) {
 					Path destination = classpath.resolve(path);
 					destination.getParent().toFile().mkdirs();
+					if (this.logger.isDebugEnabled()) {
+						this.logger.debug("Copying " + path + " to " + destination);
+					}
 					Files.copy(resource.getInputStream(), destination);
 				}
 			}