Skip to content

Commit 889f73f

Browse files
onRequest and onResponse are void now in OtelHttpClientHandler.
1 parent 5db52a3 commit 889f73f

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

spring-cloud-sleuth-otel/src/main/java/org/springframework/cloud/sleuth/otel/bridge/OtelHttpClientHandler.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -107,29 +107,25 @@ private Span span(HttpClientRequest request, io.opentelemetry.api.trace.Span spa
107107
}
108108

109109
@Override
110-
protected io.opentelemetry.api.trace.Span onRequest(io.opentelemetry.api.trace.Span span,
111-
HttpClientRequest httpClientRequest) {
112-
io.opentelemetry.api.trace.Span afterRequest = super.onRequest(span, httpClientRequest);
110+
protected void onRequest(io.opentelemetry.api.trace.Span span, HttpClientRequest httpClientRequest) {
111+
super.onRequest(span, httpClientRequest);
113112
if (this.httpClientRequestParser != null) {
114-
Span fromOtel = OtelSpan.fromOtel(afterRequest);
113+
Span fromOtel = OtelSpan.fromOtel(span);
115114
this.httpClientRequestParser.parse(httpClientRequest, fromOtel.context(), fromOtel);
116115
}
117116
String path = httpClientRequest.path();
118117
if (path != null) {
119118
span.setAttribute("http.path", path);
120119
}
121-
return afterRequest;
122120
}
123121

124122
@Override
125-
protected io.opentelemetry.api.trace.Span onResponse(io.opentelemetry.api.trace.Span span,
126-
HttpClientResponse httpClientResponse) {
127-
io.opentelemetry.api.trace.Span afterResponse = super.onResponse(span, httpClientResponse);
123+
protected void onResponse(io.opentelemetry.api.trace.Span span, HttpClientResponse httpClientResponse) {
124+
super.onResponse(span, httpClientResponse);
128125
if (this.httpClientResponseParser != null) {
129-
Span fromOtel = OtelSpan.fromOtel(afterResponse);
126+
Span fromOtel = OtelSpan.fromOtel(span);
130127
this.httpClientResponseParser.parse(httpClientResponse, fromOtel.context(), fromOtel);
131128
}
132-
return afterResponse;
133129
}
134130

135131
@Override

0 commit comments

Comments
 (0)