Skip to content

Commit 4a54643

Browse files
committed
fix: Refactored chat memory implementation to use MessageWindowChatMemory
Signed-off-by: Christian Tzolov <[email protected]>
1 parent 58ae24c commit 4a54643

File tree

3 files changed

+7
-7
lines changed
  • agents/reflection/src/main/java/org/springframework/ai/openai/samples/helloworld
  • model-context-protocol
    • sqlite/chatbot/src/main/java/org/springframework/ai/mcp/samples/sqlite
    • web-search/brave-chatbot/src/main/java/org/springframework/ai/mcp/samples/brave

3 files changed

+7
-7
lines changed

agents/reflection/src/main/java/org/springframework/ai/openai/samples/helloworld/ReflectionAgent.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import org.springframework.ai.chat.client.ChatClient;
1919
import org.springframework.ai.chat.client.advisor.MessageChatMemoryAdvisor;
20-
import org.springframework.ai.chat.memory.InMemoryChatMemory;
20+
import org.springframework.ai.chat.memory.MessageWindowChatMemory;
2121
import org.springframework.ai.chat.model.ChatModel;
2222
import org.springframework.stereotype.Component;
2323

@@ -36,7 +36,7 @@ public ReflectionAgent(ChatModel chatModel) {
3636
Your task is to Generate the best content possible for the user's request. If the user provides critique,
3737
respond with a revised version of your previous attempt.
3838
""")
39-
.defaultAdvisors(new MessageChatMemoryAdvisor(new InMemoryChatMemory()))
39+
.defaultAdvisors(new MessageChatMemoryAdvisor(MessageWindowChatMemory.builder().build()))
4040
.build();
4141

4242
this.critiqueChatClient = ChatClient.builder(chatModel)
@@ -45,7 +45,7 @@ public ReflectionAgent(ChatModel chatModel) {
4545
If the user content has something wrong or something to be improved, output a list of recommendations
4646
and critiques. If the user content is ok and there's nothing to change, output this: <OK>
4747
""")
48-
.defaultAdvisors(new MessageChatMemoryAdvisor(new InMemoryChatMemory()))
48+
.defaultAdvisors(new MessageChatMemoryAdvisor(MessageWindowChatMemory.builder().build()))
4949
.build();
5050
}
5151

model-context-protocol/sqlite/chatbot/src/main/java/org/springframework/ai/mcp/samples/sqlite/Application.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
import org.springframework.ai.chat.client.ChatClient;
1414
import org.springframework.ai.chat.client.advisor.MessageChatMemoryAdvisor;
15-
import org.springframework.ai.chat.memory.InMemoryChatMemory;
15+
import org.springframework.ai.chat.memory.MessageWindowChatMemory;
1616
import org.springframework.ai.mcp.SyncMcpToolCallbackProvider;
1717
import org.springframework.boot.CommandLineRunner;
1818
import org.springframework.boot.SpringApplication;
@@ -35,7 +35,7 @@ public CommandLineRunner interactiveChat(ChatClient.Builder chatClientBuilder,
3535

3636
var chatClient = chatClientBuilder
3737
.defaultToolCallbacks(new SyncMcpToolCallbackProvider(mcpClients))
38-
.defaultAdvisors(new MessageChatMemoryAdvisor(new InMemoryChatMemory()))
38+
.defaultAdvisors(new MessageChatMemoryAdvisor(MessageWindowChatMemory.builder().build()))
3939
.build();
4040

4141
var scanner = new Scanner(System.in);

model-context-protocol/web-search/brave-chatbot/src/main/java/org/springframework/ai/mcp/samples/brave/Application.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import org.springframework.ai.chat.client.ChatClient;
99
import org.springframework.ai.chat.client.advisor.MessageChatMemoryAdvisor;
10-
import org.springframework.ai.chat.memory.InMemoryChatMemory;
10+
import org.springframework.ai.chat.memory.MessageWindowChatMemory;
1111
import org.springframework.ai.mcp.SyncMcpToolCallbackProvider;
1212
import org.springframework.boot.CommandLineRunner;
1313
import org.springframework.boot.SpringApplication;
@@ -29,7 +29,7 @@ public CommandLineRunner chatbot(ChatClient.Builder chatClientBuilder, List<McpS
2929
var chatClient = chatClientBuilder
3030
.defaultSystem("You are useful assistant and can perform web searches Brave's search API to reply to your questions.")
3131
.defaultToolCallbacks(new SyncMcpToolCallbackProvider(mcpSyncClients))
32-
.defaultAdvisors(new MessageChatMemoryAdvisor(new InMemoryChatMemory()))
32+
.defaultAdvisors(new MessageChatMemoryAdvisor(MessageWindowChatMemory.builder().build()))
3333
.build();
3434

3535
// Start the chat loop

0 commit comments

Comments
 (0)