Skip to content

Commit 02e280c

Browse files
committed
Add default ChatOptions to Prompt
- Remove @nullable on ChatOptions - By default, pass the default ChatOptions from the DefaultChatOptionsBuilder Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
1 parent 7f0a97d commit 02e280c

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

spring-ai-client-chat/src/test/java/org/springframework/ai/chat/client/DefaultChatClientTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ void whenPromptWithMessagesThenReturn() {
110110
assertThat(spec.getMessages()).hasSize(2);
111111
assertThat(spec.getMessages().get(0).getText()).isEqualTo("instructions");
112112
assertThat(spec.getMessages().get(1).getText()).isEqualTo("my question");
113-
assertThat(spec.getChatOptions()).isNull();
113+
assertThat(spec.getChatOptions()).isNotNull();
114+
assertThat(spec.getChatOptions()).isInstanceOf(ChatOptions.class);
114115
}
115116

116117
@Test

spring-ai-model/src/main/java/org/springframework/ai/chat/prompt/Prompt.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public class Prompt implements ModelRequest<List<Message>> {
4545

4646
private final List<Message> messages;
4747

48-
@Nullable
4948
private ChatOptions chatOptions;
5049

5150
public Prompt(String contents) {
@@ -57,24 +56,24 @@ public Prompt(Message message) {
5756
}
5857

5958
public Prompt(List<Message> messages) {
60-
this(messages, null);
59+
this(messages, ChatOptions.builder().build());
6160
}
6261

6362
public Prompt(Message... messages) {
64-
this(Arrays.asList(messages), null);
63+
this(Arrays.asList(messages), ChatOptions.builder().build());
6564
}
6665

67-
public Prompt(String contents, @Nullable ChatOptions chatOptions) {
66+
public Prompt(String contents, ChatOptions chatOptions) {
6867
this(new UserMessage(contents), chatOptions);
6968
}
7069

71-
public Prompt(Message message, @Nullable ChatOptions chatOptions) {
70+
public Prompt(Message message, ChatOptions chatOptions) {
7271
this(Collections.singletonList(message), chatOptions);
7372
}
7473

75-
public Prompt(List<Message> messages, @Nullable ChatOptions chatOptions) {
74+
public Prompt(List<Message> messages, ChatOptions chatOptions) {
7675
this.messages = messages;
77-
this.chatOptions = chatOptions;
76+
this.chatOptions = (chatOptions != null) ? chatOptions : ChatOptions.builder().build();
7877
}
7978

8079
public String getContents() {
@@ -86,7 +85,6 @@ public String getContents() {
8685
}
8786

8887
@Override
89-
@Nullable
9088
public ChatOptions getOptions() {
9189
return this.chatOptions;
9290
}

0 commit comments

Comments
 (0)