Skip to content

Commit 13f3a6c

Browse files
committed
[GH-3723] addressing review comments
Closes GH-3723 Signed-off-by: Rodrigo Malara <[email protected]>
1 parent 4965fc9 commit 13f3a6c

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

models/spring-ai-vertex-ai-gemini/src/main/java/org/springframework/ai/vertexai/gemini/VertexAiGeminiChatModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import io.micrometer.observation.contextpropagation.ObservationThreadLocalAccessor;
5050
import org.slf4j.Logger;
5151
import org.slf4j.LoggerFactory;
52-
import org.springframework.ai.vertexai.gemini.api.VertexAiGeminiApi;
5352
import reactor.core.publisher.Flux;
5453
import reactor.core.scheduler.Schedulers;
5554

@@ -85,6 +84,7 @@
8584
import org.springframework.ai.retry.RetryUtils;
8685
import org.springframework.ai.support.UsageCalculator;
8786
import org.springframework.ai.tool.definition.ToolDefinition;
87+
import org.springframework.ai.vertexai.gemini.api.VertexAiGeminiApi;
8888
import org.springframework.ai.vertexai.gemini.common.VertexAiGeminiConstants;
8989
import org.springframework.ai.vertexai.gemini.common.VertexAiGeminiSafetySetting;
9090
import org.springframework.ai.vertexai.gemini.schema.VertexToolCallingManager;

models/spring-ai-vertex-ai-gemini/src/main/java/org/springframework/ai/vertexai/gemini/VertexAiGeminiChatOptions.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,7 @@ public int hashCode() {
387387
return Objects.hash(this.stopSequences, this.temperature, this.topP, this.topK, this.candidateCount,
388388
this.frequencyPenalty, this.presencePenalty, this.maxOutputTokens, this.model, this.responseMimeType,
389389
this.toolCallbacks, this.toolNames, this.googleSearchRetrieval, this.safetySettings,
390-
this.internalToolExecutionEnabled, this.toolContext, this.toolContext, this.logprobs,
391-
this.responseLogprobs);
390+
this.internalToolExecutionEnabled, this.toolContext, this.logprobs, this.responseLogprobs);
392391
}
393392

394393
@Override

models/spring-ai-vertex-ai-gemini/src/main/java/org/springframework/ai/vertexai/gemini/api/VertexAiGeminiApi.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
/*
2+
* Copyright 2023-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
116
package org.springframework.ai.vertexai.gemini.api;
217

318
import java.util.List;

0 commit comments

Comments
 (0)