address review suggestions

Author: tzolov

spring-ai-core/src/main/java/org/springframework/ai/chat/model/AbstractToolCallSupport.java

@@ -184,8 +184,7 @@ protected List<FunctionCallback> resolveFunctionCallbacks(Set<String> functionNa
 			if (!this.functionCallbackRegister.containsKey(functionName)) {
 
 				if (this.functionCallbackResolver != null) {
-					FunctionCallback functionCallback = this.functionCallbackResolver.getFunctionCallback(functionName,
-							null);
+					FunctionCallback functionCallback = this.functionCallbackResolver.resolve(functionName);
 					if (functionCallback != null) {
 						this.functionCallbackRegister.put(functionName, functionCallback);
 					}

spring-ai-core/src/main/java/org/springframework/ai/model/function/DefaultFunctionCallbackResolver.java

@@ -73,20 +73,19 @@ public void setApplicationContext(@NonNull ApplicationContext applicationContext
 	}
 
 	@Override
-	public FunctionCallback getFunctionCallback(@NonNull String beanName, @Nullable String defaultDescription) {
+	public FunctionCallback resolve(@NonNull String beanName) {
 		ResolvableType functionType = TypeResolverHelper.resolveBeanType(this.applicationContext, beanName);
 		ResolvableType functionInputType = (ResolvableType.forType(Supplier.class).isAssignableFrom(functionType))
 				? ResolvableType.forType(Void.class) : TypeResolverHelper.getFunctionArgumentType(functionType, 0);
 
-		String functionDescription = resolveFunctionDescription(beanName, defaultDescription,
-				functionInputType.toClass());
+		String functionDescription = resolveFunctionDescription(beanName, functionInputType.toClass());
 		Object bean = this.applicationContext.getBean(beanName);
 
 		return buildFunctionCallback(beanName, functionType, functionInputType, functionDescription, bean);
 	}
 
-	private String resolveFunctionDescription(String beanName, String defaultDescription, Class<?> functionInputClass) {
-		String functionDescription = defaultDescription;
+	private String resolveFunctionDescription(String beanName, Class<?> functionInputClass) {
+		String functionDescription = "";
 
 		if (!StringUtils.hasText(functionDescription)) {
 			Description descriptionAnnotation = this.applicationContext.findAnnotationOnBean(beanName,

spring-ai-core/src/main/java/org/springframework/ai/model/function/FunctionCallbackResolver.java

@@ -16,11 +16,9 @@
 package org.springframework.ai.model.function;
 
 import org.springframework.lang.NonNull;
-import org.springframework.lang.Nullable;
 
 /**
- * Strategy interface for resolving {@link FunctionCallback} instances as bean from the
- * application context.
+ * Strategy interface for resolving {@link FunctionCallback} instances.
  *
  * @author Christian Tzolov
  * @since 1.0.0
@@ -29,9 +27,9 @@ public interface FunctionCallbackResolver {
 
 	/**
 	 * Resolve the {@link FunctionCallback} instance by its bean name.
-	 * @param beanName the name of the bean to resolve
+	 * @param name the name of the function to resolve
 	 * @return the {@link FunctionCallback} instance
 	 */
-	FunctionCallback getFunctionCallback(@NonNull String beanName, @Nullable String defaultDescription);
+	FunctionCallback resolve(@NonNull String name);
 
 }