Skip to content

Commit 351dfc2

Browse files
sobychackomarkpollack
authored andcommitted
Pinecone vector store builder refactoring
1 parent d4a6e1e commit 351dfc2

File tree

9 files changed

+305
-101
lines changed

9 files changed

+305
-101
lines changed

spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/pinecone/PineconeVectorStoreAutoConfiguration.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import org.springframework.ai.embedding.BatchingStrategy;
2222
import org.springframework.ai.embedding.EmbeddingModel;
2323
import org.springframework.ai.embedding.TokenCountBatchingStrategy;
24-
import org.springframework.ai.vectorstore.PineconeVectorStore;
25-
import org.springframework.ai.vectorstore.PineconeVectorStore.PineconeVectorStoreConfig;
24+
import org.springframework.ai.vectorstore.pinecone.PineconeVectorStore;
25+
import org.springframework.ai.vectorstore.pinecone.PineconeVectorStore.PineconeVectorStoreConfig;
2626
import org.springframework.ai.vectorstore.observation.VectorStoreObservationConvention;
2727
import org.springframework.beans.factory.ObjectProvider;
2828
import org.springframework.boot.autoconfigure.AutoConfiguration;
@@ -55,20 +55,20 @@ public PineconeVectorStore vectorStore(EmbeddingModel embeddingModel, PineconeVe
5555
ObjectProvider<VectorStoreObservationConvention> customObservationConvention,
5656
BatchingStrategy batchingStrategy) {
5757

58-
var config = PineconeVectorStoreConfig.builder()
59-
.withApiKey(properties.getApiKey())
60-
.withEnvironment(properties.getEnvironment())
61-
.withProjectId(properties.getProjectId())
62-
.withIndexName(properties.getIndexName())
63-
.withNamespace(properties.getNamespace())
64-
.withContentFieldName(properties.getContentFieldName())
65-
.withDistanceMetadataFieldName(properties.getDistanceMetadataFieldName())
66-
.withServerSideTimeout(properties.getServerSideTimeout())
58+
return PineconeVectorStore.builder()
59+
.embeddingModel(embeddingModel)
60+
.apiKey(properties.getApiKey())
61+
.environment(properties.getEnvironment())
62+
.projectId(properties.getProjectId())
63+
.indexName(properties.getIndexName())
64+
.namespace(properties.getNamespace())
65+
.contentFieldName(properties.getContentFieldName())
66+
.distanceMetadataFieldName(properties.getDistanceMetadataFieldName())
67+
.serverSideTimeout(properties.getServerSideTimeout())
68+
.observationRegistry(observationRegistry.getIfUnique(() -> ObservationRegistry.NOOP))
69+
.customObservationConvention(customObservationConvention.getIfAvailable(() -> null))
70+
.batchingStrategy(batchingStrategy)
6771
.build();
68-
69-
return new PineconeVectorStore(config, embeddingModel,
70-
observationRegistry.getIfUnique(() -> ObservationRegistry.NOOP),
71-
customObservationConvention.getIfAvailable(() -> null), batchingStrategy);
7272
}
7373

7474
}

spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/pinecone/PineconeVectorStoreProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.time.Duration;
2020

2121
import org.springframework.ai.document.DocumentMetadata;
22-
import org.springframework.ai.vectorstore.PineconeVectorStore;
22+
import org.springframework.ai.vectorstore.pinecone.PineconeVectorStore;
2323
import org.springframework.boot.context.properties.ConfigurationProperties;
2424

2525
/**

spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/pinecone/PineconeVectorStoreAutoConfigurationIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import org.springframework.ai.embedding.EmbeddingModel;
3434
import org.springframework.ai.observation.conventions.VectorStoreProvider;
3535
import org.springframework.ai.transformers.TransformersEmbeddingModel;
36-
import org.springframework.ai.vectorstore.PineconeVectorStore;
36+
import org.springframework.ai.vectorstore.pinecone.PineconeVectorStore;
3737
import org.springframework.ai.vectorstore.SearchRequest;
3838
import org.springframework.ai.vectorstore.observation.VectorStoreObservationContext;
3939
import org.springframework.boot.autoconfigure.AutoConfigurations;

spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/pinecone/PineconeVectorStorePropertiesTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.junit.jupiter.api.Test;
2222

2323
import org.springframework.ai.document.DocumentMetadata;
24-
import org.springframework.ai.vectorstore.PineconeVectorStore;
24+
import org.springframework.ai.vectorstore.pinecone.PineconeVectorStore;
2525

2626
import static org.assertj.core.api.Assertions.assertThat;
2727

0 commit comments

Comments
 (0)