Adding Oracle Dialect

Author: psilberk

memory/repository/spring-ai-model-chat-memory-repository-jdbc/pom.xml

@@ -50,13 +50,7 @@
 			<artifactId>spring-jdbc</artifactId>
 		</dependency>
 
-		<dependency>
-			<groupId>com.zaxxer</groupId>
-			<artifactId>HikariCP</artifactId>
-		</dependency>
-
 		<!-- TESTING -->
-
 		<dependency>
 			<groupId>org.postgresql</groupId>
 			<artifactId>postgresql</artifactId>
@@ -89,7 +83,13 @@
 		<dependency>
 			<groupId>com.oracle.database.jdbc</groupId>
 			<artifactId>ojdbc8</artifactId>
-			<version>21.13.0.0</version>
+			<version>23.9.0.25.07</version>
+			<scope>test</scope>
+		</dependency>
+
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-jdbc</artifactId>
 			<scope>test</scope>
 		</dependency>
 

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/OracleChatMemoryRepositoryDialect.java

@@ -27,12 +27,12 @@ public class OracleChatMemoryRepositoryDialect implements JdbcChatMemoryReposito
 
 	@Override
 	public String getSelectMessagesSql() {
-		return "SELECT content, type FROM SPRING_AI_CHAT_MEMORY WHERE conversation_id = ? ORDER BY \"timestamp\"";
+		return "SELECT content, type FROM SPRING_AI_CHAT_MEMORY WHERE CONVERSATION_ID = ? ORDER BY \"TIMESTAMP\"";
 	}
 
 	@Override
 	public String getInsertMessageSql() {
-		return "INSERT INTO SPRING_AI_CHAT_MEMORY (conversation_id, content, type, \"timestamp\") VALUES (?, ?, ?, ?)";
+		return "INSERT INTO SPRING_AI_CHAT_MEMORY (CONVERSATION_ID, CONTENT, TYPE, \"TIMESTAMP\") VALUES (?, ?, ?, ?)";
 	}
 
 	@Override
@@ -42,7 +42,7 @@ public String getSelectConversationIdsSql() {
 
 	@Override
 	public String getDeleteMessagesSql() {
-		return "DELETE FROM SPRING_AI_CHAT_MEMORY WHERE conversation_id = ?";
+		return "DELETE FROM SPRING_AI_CHAT_MEMORY WHERE CONVERSATION_ID = ?";
 	}
 
 	/**

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/resources/org/springframework/ai/chat/memory/repository/jdbc/schema-oracle.sql

@@ -1,9 +1,21 @@
+DROP TABLE SPRING_AI_CHAT_MEMORY;
+
 CREATE TABLE SPRING_AI_CHAT_MEMORY (
-    conversation_id VARCHAR2(36) NOT NULL,
-    content CLOB NOT NULL,
-    type VARCHAR2(10) NOT NULL CHECK (type IN ('USER', 'ASSISTANT', 'SYSTEM', 'TOOL')),
-    "timestamp" TIMESTAMP NOT NULL
+    CONVERSATION_ID VARCHAR2(36 CHAR) NOT NULL,
+    CONTENT CLOB NOT NULL,
+    "TYPE" VARCHAR2(10 CHAR) NOT NULL CHECK (
+        "TYPE" IN (
+            'USER',
+            'ASSISTANT',
+            'SYSTEM',
+            'TOOL'
+        )
+    ),
+    "TIMESTAMP" TIMESTAMP NOT NULL
 );
 
-CREATE INDEX idx_conversation_id ON SPRING_AI_CHAT_MEMORY(conversation_id);
-CREATE INDEX idx_conversation_id_timestamp ON SPRING_AI_CHAT_MEMORY(conversation_id, "timestamp");
+CREATE INDEX SPRING_AI_CHAT_MEMORY_CONVERSATION_ID_TIMESTAMP_IDX
+    ON SPRING_AI_CHAT_MEMORY(
+        CONVERSATION_ID,
+        'TIMESTAMP'
+    );

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryOracleIT.java

@@ -27,7 +27,8 @@
  */
 
 @SpringBootTest
-@TestPropertySource(properties = { "spring.datasource.url=jdbc:tc:oracle:21.3.0.0:///" })
+@TestPropertySource(properties = { "spring.datasource.url=jdbc:oracle:thin:@localhost:1521/FREEPDB1",
+		"spring.datasource.username=scott", "spring.datasource.password=tiger" })
 @Sql(scripts = "classpath:org/springframework/ai/chat/memory/repository/jdbc/schema-oracle.sql")
 public class JdbcChatMemoryRepositoryOracleIT extends AbstractJdbcChatMemoryRepositoryIT {