Skip to content

Commit 4b44359

Browse files
committed
refactor(azure): replace LinkedHashMap with HashMap in parseMetadataToMutable
We don’t rely on insertion order for metadata, so a regular HashMap is sufficient. This change addresses reviewer feedback while still ensuring the returned map is always mutable by creating a defensive copy or returning an empty instance. Relates to #4117 Signed-off-by: Jinwoo Lee <[email protected]>
1 parent 4ab833a commit 4b44359

File tree

1 file changed

+4
-4
lines changed
  • vector-stores/spring-ai-azure-store/src/main/java/org/springframework/ai/vectorstore/azure

1 file changed

+4
-4
lines changed

vector-stores/spring-ai-azure-store/src/main/java/org/springframework/ai/vectorstore/azure/AzureVectorStore.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import java.util.ArrayList;
2020
import java.util.Collections;
21-
import java.util.LinkedHashMap;
21+
import java.util.HashMap;
2222
import java.util.List;
2323
import java.util.Map;
2424
import java.util.Optional;
@@ -325,16 +325,16 @@ public <T> Optional<T> getNativeClient() {
325325

326326
static Map<String, Object> parseMetadataToMutable(@Nullable String metadataJson) {
327327
if (!StringUtils.hasText(metadataJson)) {
328-
return new LinkedHashMap<>();
328+
return new HashMap<>();
329329
}
330330
try {
331331
Map<String, Object> parsed = JSONObject.parseObject(metadataJson, new TypeReference<Map<String, Object>>() {
332332
});
333-
return (parsed == null) ? new LinkedHashMap<>() : new LinkedHashMap<>(parsed);
333+
return (parsed == null) ? new HashMap<>() : new HashMap<>(parsed);
334334
}
335335
catch (Exception ex) {
336336
logger.warn("Failed to parse metadata JSON. Using empty metadata. json={}", metadataJson, ex);
337-
return new LinkedHashMap<>();
337+
return new HashMap<>();
338338
}
339339
}
340340

0 commit comments

Comments
 (0)