SyncMcpToolCallback call method NPE

Fj-ivy · fangjie33 · commit 5771a98e8ed0 · 2025-03-12T21:19:28.000+08:00
Signed-off-by: fangjie33 &lt;fangjie33@jd.com&gt;
diff --git a/mcp/common/src/main/java/org/springframework/ai/mcp/SyncMcpToolCallback.java b/mcp/common/src/main/java/org/springframework/ai/mcp/SyncMcpToolCallback.java
@@ -113,7 +113,7 @@ public String call(String functionInput) {
 		// Note that we use the original tool name here, not the adapted one from
 		// getToolDefinition
 		CallToolResult response = this.mcpClient.callTool(new CallToolRequest(this.tool.name(), arguments));
-		if (response.isError()) {
+		if (response.isError() != null && response.isError()) {
 			throw new IllegalStateException("Error calling tool: " + response.content());
 		}
 		return ModelOptionsUtils.toJsonString(response.content());

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public String call(String functionInput) {`
`113`	`113`	`// Note that we use the original tool name here, not the adapted one from`
`114`	`114`	`// getToolDefinition`
`115`	`115`	`CallToolResult response = this.mcpClient.callTool(new CallToolRequest(this.tool.name(), arguments));`
`116`		`- if (response.isError()) {`
	`116`	`+ if (response.isError() != null && response.isError()) {`
`117`	`117`	`throw new IllegalStateException("Error calling tool: " + response.content());`
`118`	`118`	`}`
`119`	`119`	`return ModelOptionsUtils.toJsonString(response.content());`