Skip to content

Commit 5d09119

Browse files
committed
test: Enhance test coverage for EmbeddingModelObservationContext
Co-authored-by: Oleksandr Klymenko <[email protected]> Signed-off-by: Oleksandr Klymenko <[email protected]>
1 parent 3165ea2 commit 5d09119

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

spring-ai-model/src/test/java/org/springframework/ai/embedding/observation/EmbeddingModelObservationContextTests.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,41 @@ void whenValidRequestAndProviderThenBuildsSuccessfully() {
8484
assertThat(observationContext).isNotNull();
8585
}
8686

87+
@Test
88+
void whenBuilderWithBlankProviderThenThrowsException() {
89+
var embeddingRequest = generateEmbeddingRequest(EmbeddingOptionsBuilder.builder().model("test-model").build());
90+
91+
assertThatThrownBy(() -> EmbeddingModelObservationContext.builder()
92+
.embeddingRequest(embeddingRequest)
93+
.provider(" ")
94+
.build()).isInstanceOf(IllegalArgumentException.class).hasMessage("provider cannot be null or empty");
95+
}
96+
97+
@Test
98+
void whenEmbeddingRequestWithNullOptionsThenBuildsSuccessfully() {
99+
var embeddingRequest = generateEmbeddingRequest(null);
100+
101+
var observationContext = EmbeddingModelObservationContext.builder()
102+
.embeddingRequest(embeddingRequest)
103+
.provider("test-provider")
104+
.build();
105+
106+
assertThat(observationContext).isNotNull();
107+
}
108+
109+
@Test
110+
void whenEmbeddingRequestWithEmptyInputListThenBuildsSuccessfully() {
111+
var embeddingRequest = new EmbeddingRequest(List.of(),
112+
EmbeddingOptionsBuilder.builder().model("test-model").build());
113+
114+
var observationContext = EmbeddingModelObservationContext.builder()
115+
.embeddingRequest(embeddingRequest)
116+
.provider("test-provider")
117+
.build();
118+
119+
assertThat(observationContext).isNotNull();
120+
}
121+
87122
private EmbeddingRequest generateEmbeddingRequest(EmbeddingOptions embeddingOptions) {
88123
return new EmbeddingRequest(List.of("test input"), embeddingOptions);
89124
}

0 commit comments

Comments
 (0)