feat(gemini) check safety settings not empty instead of not null

terussell85 · terussell85 · commit 5d6b5893cc51 · 2024-12-04T10:32:13.000-07:00
diff --git a/models/spring-ai-vertex-ai-gemini/src/main/java/org/springframework/ai/vertexai/gemini/VertexAiGeminiChatModel.java b/models/spring-ai-vertex-ai-gemini/src/main/java/org/springframework/ai/vertexai/gemini/VertexAiGeminiChatModel.java
@@ -500,7 +500,8 @@ GeminiRequest createGeminiRequest(Prompt prompt, VertexAiGeminiChatOptions updat
 			generativeModelBuilder.setTools(tools);
 		}
 
-		if (prompt.getOptions() instanceof VertexAiGeminiChatOptions options && options.getSafetySettings() != null) {
+		if (prompt.getOptions() instanceof VertexAiGeminiChatOptions options
+				&& !CollectionUtils.isEmpty(options.getSafetySettings())) {
 			generativeModelBuilder.setSafetySettings(options.getSafetySettings());
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,8 @@ GeminiRequest createGeminiRequest(Prompt prompt, VertexAiGeminiChatOptions updat`
`500`	`500`	`generativeModelBuilder.setTools(tools);`
`501`	`501`	`}`
`502`	`502`
`503`		`- if (prompt.getOptions() instanceof VertexAiGeminiChatOptions options && options.getSafetySettings() != null) {`
	`503`	`+ if (prompt.getOptions() instanceof VertexAiGeminiChatOptions options`
	`504`	`+ && !CollectionUtils.isEmpty(options.getSafetySettings())) {`
`504`	`505`	`generativeModelBuilder.setSafetySettings(options.getSafetySettings());`
`505`	`506`	`}`
`506`	`507`