Skip to content

Commit 601a7da

Browse files
committed
Revert "Make ImageOptions non-null when constructing ImagePrompt"
This reverts commit 0c0787b.
1 parent 092adc9 commit 601a7da

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/OpenAiRetryTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import org.springframework.ai.chat.prompt.Prompt;
3535
import org.springframework.ai.document.MetadataMode;
3636
import org.springframework.ai.image.ImageMessage;
37+
import org.springframework.ai.image.ImageOptionsBuilder;
3738
import org.springframework.ai.image.ImagePrompt;
3839
import org.springframework.ai.openai.OpenAiAudioTranscriptionModel;
3940
import org.springframework.ai.openai.OpenAiAudioTranscriptionOptions;
@@ -250,7 +251,8 @@ public void openAiImageTransientError() {
250251
.willThrow(new TransientAiException("Transient Error 2"))
251252
.willReturn(ResponseEntity.of(Optional.of(expectedResponse)));
252253

253-
var result = this.imageModel.call(new ImagePrompt(List.of(new ImageMessage("Image Message"))));
254+
var result = this.imageModel
255+
.call(new ImagePrompt(List.of(new ImageMessage("Image Message")), ImageOptionsBuilder.builder().build()));
254256

255257
assertThat(result).isNotNull();
256258
assertThat(result.getResult().getOutput().getUrl()).isEqualTo("url678");
@@ -262,8 +264,8 @@ public void openAiImageTransientError() {
262264
public void openAiImageNonTransientError() {
263265
given(this.openAiImageApi.createImage(isA(OpenAiImageRequest.class)))
264266
.willThrow(new RuntimeException("Transient Error 1"));
265-
assertThrows(RuntimeException.class,
266-
() -> this.imageModel.call(new ImagePrompt(List.of(new ImageMessage("Image Message")))));
267+
assertThrows(RuntimeException.class, () -> this.imageModel
268+
.call(new ImagePrompt(List.of(new ImageMessage("Image Message")), ImageOptionsBuilder.builder().build())));
267269
}
268270

269271
private static class TestRetryListener implements RetryListener {

spring-ai-model/src/main/java/org/springframework/ai/image/ImagePrompt.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@ public class ImagePrompt implements ModelRequest<List<ImageMessage>> {
2929
private ImageOptions imageModelOptions;
3030

3131
public ImagePrompt(List<ImageMessage> messages) {
32-
this(messages, ImageOptionsBuilder.builder().build());
32+
this.messages = messages;
33+
}
34+
35+
public ImagePrompt(List<ImageMessage> messages, ImageOptions imageModelOptions) {
36+
this.messages = messages;
37+
this.imageModelOptions = imageModelOptions;
3338
}
3439

3540
public ImagePrompt(ImageMessage imageMessage, ImageOptions imageOptions) {
@@ -44,11 +49,6 @@ public ImagePrompt(String instructions) {
4449
this(new ImageMessage(instructions), ImageOptionsBuilder.builder().build());
4550
}
4651

47-
public ImagePrompt(List<ImageMessage> messages, ImageOptions imageModelOptions) {
48-
this.messages = messages;
49-
this.imageModelOptions = imageModelOptions != null ? imageModelOptions : ImageOptionsBuilder.builder().build();
50-
}
51-
5252
@Override
5353
public List<ImageMessage> getInstructions() {
5454
return this.messages;

0 commit comments

Comments
 (0)