Commit 76708a1
fix: Handling default implementation of ToolCallback#call(String,ToolContext)
Context: Currently, the default implementation of ToolCallback#call(String,ToolContext) throws exception when an non-empty ToolContext is passed. This gives bad user experience when the application has multiple tool callbacks with one of them doesn't use toolcontext but the chat client passes non-empty toolcontext. For more information ##3389
- This fix removes the explicit exception when the toolcontext is non empty for the default implementation of call(String, ToolContext)
- Instead, log info message that tool context will be ignored
Fixes #3389
Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
(cherry picked from commit 3e17e16)1 parent 779b304 commit 76708a1
File tree
1 file changed
+8
-1
lines changed- spring-ai-model/src/main/java/org/springframework/ai/tool
1 file changed
+8
-1
lines changedLines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
29 | 32 | | |
30 | 33 | | |
31 | 34 | | |
| 35 | + | |
| 36 | + | |
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
| |||
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
56 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
| |||
0 commit comments