More checkstyle changes

Author: sobychacko

models/spring-ai-postgresml/pom.xml

@@ -36,6 +36,10 @@
 		<developerConnection>[email protected]:spring-projects/spring-ai.git</developerConnection>
 	</scm>
 
+	<properties>
+		<disable.checks>false</disable.checks>
+	</properties>
+
 	<dependencies>
 		<dependency>
 			<groupId>org.springframework.ai</groupId>

models/spring-ai-qianfan/pom.xml

@@ -36,6 +36,10 @@
         <developerConnection>[email protected]:spring-projects/spring-ai.git</developerConnection>
     </scm>
 
+	<properties>
+		<disable.checks>false</disable.checks>
+	</properties>
+
     <dependencies>
 
         <!-- production dependencies -->

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/QianFanChatModel.java

@@ -223,9 +223,7 @@ public Flux<ChatResponse> stream(Prompt prompt) {
 					return new ChatResponse(generations, from(chatCompletion, request.model()));
 				}))
 				.doOnError(observation::error)
-				.doFinally(s -> {
-					observation.stop();
-				})
+				.doFinally(s -> observation.stop())
 				.contextWrite(ctx -> ctx.put(ObservationThreadLocalAccessor.KEY, observation));
 			return new MessageAggregator().aggregate(chatResponse, observationContext::setResponse);
 

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/QianFanImageOptions.java

@@ -31,7 +31,7 @@
  * @since 1.0
  */
 @JsonInclude(JsonInclude.Include.NON_NULL)
-public class QianFanImageOptions implements ImageOptions {
+public final class QianFanImageOptions implements ImageOptions {
 
 	/**
 	 * The number of images to generate. Must be between 1 and 4.
@@ -188,7 +188,7 @@ public String toString() {
 				+ ", user='" + this.user + '\'' + '}';
 	}
 
-	public static class Builder {
+	public static final class Builder {
 
 		private final QianFanImageOptions options;
 

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/aot/QianFanRuntimeHints.java

@@ -37,10 +37,12 @@ public class QianFanRuntimeHints implements RuntimeHintsRegistrar {
 	@Override
 	public void registerHints(@NonNull RuntimeHints hints, @Nullable ClassLoader classLoader) {
 		var mcs = MemberCategory.values();
-		for (var tr : findJsonAnnotatedClassesInPackage(QianFanApi.class))
+		for (var tr : findJsonAnnotatedClassesInPackage(QianFanApi.class)) {
 			hints.reflection().registerType(tr, mcs);
-		for (var tr : findJsonAnnotatedClassesInPackage(QianFanImageApi.class))
+		}
+		for (var tr : findJsonAnnotatedClassesInPackage(QianFanImageApi.class)) {
 			hints.reflection().registerType(tr, mcs);
+		}
 	}
 
 }

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/api/QianFanApi.java

@@ -112,7 +112,7 @@ public QianFanApi(String baseUrl, String apiKey, String secretKey, RestClient.Bu
 	 * @param responseErrorHandler Response error handler.
 	 */
 	public QianFanApi(String baseUrl, String apiKey, String secretKey, RestClient.Builder restClientBuilder,
-					  WebClient.Builder webClientBuilder, ResponseErrorHandler responseErrorHandler) {
+					WebClient.Builder webClientBuilder, ResponseErrorHandler responseErrorHandler) {
 		super(apiKey, secretKey);
 
 		this.restClient = restClientBuilder
@@ -139,7 +139,7 @@ public ResponseEntity<ChatCompletion> chatCompletionEntity(ChatCompletionRequest
 		Assert.isTrue(!chatRequest.stream(), "Request must set the stream property to false.");
 
 		return this.restClient.post()
-				.uri("/v1/wenxinworkshop/chat/{model}?access_token={token}",chatRequest.model, getAccessToken())
+				.uri("/v1/wenxinworkshop/chat/{model}?access_token={token}", chatRequest.model, getAccessToken())
 				.body(chatRequest)
 				.retrieve()
 				.toEntity(ChatCompletion.class);
@@ -156,7 +156,7 @@ public Flux<ChatCompletionChunk> chatCompletionStream(ChatCompletionRequest chat
 		Assert.isTrue(chatRequest.stream(), "Request must set the stream property to true.");
 
 		return this.webClient.post()
-				.uri("/v1/wenxinworkshop/chat/{model}?access_token={token}",chatRequest.model, getAccessToken())
+				.uri("/v1/wenxinworkshop/chat/{model}?access_token={token}", chatRequest.model, getAccessToken())
 				.body(Mono.just(chatRequest), ChatCompletionRequest.class)
 				.retrieve()
 				.bodyToFlux(ChatCompletionChunk.class)
@@ -287,7 +287,7 @@ public String getValue() {
 	 * probability mass are considered. We generally recommend altering this or temperature but not both.
 	 */
 	@JsonInclude(Include.NON_NULL)
-	public record ChatCompletionRequest (
+	public record ChatCompletionRequest(
 			@JsonProperty("messages") List<ChatCompletionMessage> messages,
 			@JsonProperty("system") String system,
 			@JsonProperty("model") String model,
@@ -308,7 +308,7 @@ public record ChatCompletionRequest (
 		 * @param temperature What sampling temperature to use, between 0 and 1.
 		 */
 		public ChatCompletionRequest(List<ChatCompletionMessage> messages, String system, String model, Double temperature) {
-			this(messages, system, model, null,null,
+			this(messages, system, model, null, null,
 					null, null, null, false, temperature, null);
 		}
 
@@ -322,7 +322,7 @@ public ChatCompletionRequest(List<ChatCompletionMessage> messages, String system
 		 * as they become available, with the stream terminated by a data: [DONE] message.
 		 */
 		public ChatCompletionRequest(List<ChatCompletionMessage> messages, String system, String model, Double temperature, boolean stream) {
-			this(messages, system, model, null,null,
+			this(messages, system, model, null, null,
 					null, null, null, stream, temperature, null);
 		}
 
@@ -336,7 +336,7 @@ public ChatCompletionRequest(List<ChatCompletionMessage> messages, String system
 		 * as they become available, with the stream terminated by a data: [DONE] message.
 		 */
 		public ChatCompletionRequest(List<ChatCompletionMessage> messages, String system, Boolean stream) {
-			this(messages, system, DEFAULT_CHAT_MODEL, null,null,
+			this(messages, system, DEFAULT_CHAT_MODEL, null, null,
 					null, null, null, stream, 0.8, null);
 		}
 
@@ -382,15 +382,18 @@ public enum Role {
 			/**
 			 * System message.
 			 */
-			@JsonProperty("system") SYSTEM,
+			@JsonProperty("system")
+			SYSTEM,
 			/**
 			 * User message.
 			 */
-			@JsonProperty("user") USER,
+			@JsonProperty("user")
+			USER,
 			/**
 			 * Assistant message.
 			 */
-			@JsonProperty("assistant") ASSISTANT
+			@JsonProperty("assistant")
+			ASSISTANT
 		}
 	}
 
@@ -483,7 +486,7 @@ public EmbeddingRequest(String text) {
 		 * @param userId A unique identifier representing your end-user, which can help QianFan to
 		 * 		monitor and detect abuse.
 		 */
-		public EmbeddingRequest(String text,String model,String userId) {
+		public EmbeddingRequest(String text, String model, String userId) {
 			this(List.of(text), model, userId);
 		}
 

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/api/QianFanConstants.java

@@ -25,10 +25,14 @@
  * @author Geng Rong
  * @since 1.0
  */
-public class QianFanConstants {
+public final class QianFanConstants {
 
 	public static final String DEFAULT_BASE_URL = "https://aip.baidubce.com/rpc/2.0/ai_custom";
 
 	public static final String PROVIDER_NAME = AiProvider.QIANFAN.value();
 
+	private QianFanConstants() {
+
+	}
+
 }

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/api/QianFanImageApi.java

@@ -114,7 +114,7 @@ public String getValue() {
 
 	// @formatter:off
 	@JsonInclude(JsonInclude.Include.NON_NULL)
-	public record QianFanImageRequest (
+	public record QianFanImageRequest(
 		@JsonProperty("model") String model,
 		@JsonProperty("prompt") String prompt,
 		@JsonProperty("negative_prompt") String negativePrompt,

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/api/QianFanUtils.java

@@ -21,10 +21,14 @@
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.MediaType;
 
-public class QianFanUtils {
+public final class QianFanUtils {
 
 	public static Consumer<HttpHeaders> defaultHeaders() {
 		return headers -> headers.setContentType(MediaType.APPLICATION_JSON);
 	}
 
+	private QianFanUtils() {
+
+	}
+
 }

models/spring-ai-qianfan/src/main/java/org/springframework/ai/qianfan/api/auth/QianFanAccessToken.java

@@ -86,4 +86,4 @@ private long getCurrentTimeInSeconds() {
 		return System.currentTimeMillis() / 1000L;
 	}
 
-}
+}