Skip to content

Commit 91d7821

Browse files
committed
Fix bug #2301. The SseHttpClientTransportAutoConfiguration will always run for the class name in @ConditionalOnMissingClass is wrong.
Signed-off-by: Mota <[email protected]>
1 parent ce8e8b9 commit 91d7821

File tree

2 files changed

+44
-1
lines changed

2 files changed

+44
-1
lines changed

auto-configurations/spring-ai-mcp-client/src/main/java/org/springframework/ai/autoconfigure/mcp/client/SseHttpClientTransportAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
*/
6464
@AutoConfiguration(after = SseWebFluxTransportAutoConfiguration.class)
6565
@ConditionalOnClass({ McpSchema.class, McpSyncClient.class })
66-
@ConditionalOnMissingClass("io.modelcontextprotocol.client.transport.public class WebFluxSseClientTransport")
66+
@ConditionalOnMissingClass("io.modelcontextprotocol.client.transport.WebFluxSseClientTransport")
6767
@EnableConfigurationProperties({ McpSseClientProperties.class, McpClientCommonProperties.class })
6868
@ConditionalOnProperty(prefix = McpClientCommonProperties.CONFIG_PREFIX, name = "enabled", havingValue = "true",
6969
matchIfMissing = true)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
/*
2+
* Copyright 2025-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.ai.autoconfigure.mcp.client;
18+
19+
import org.junit.jupiter.api.Test;
20+
import org.springframework.beans.factory.annotation.Autowired;
21+
import org.springframework.context.ApplicationContext;
22+
import org.springframework.context.annotation.Import;
23+
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
24+
25+
import static org.junit.jupiter.api.Assertions.assertFalse;
26+
27+
@SpringJUnitConfig
28+
@Import(SseHttpClientTransportAutoConfiguration.class)
29+
public class SseHttpClientTransportAutoConfigurationTest {
30+
@Autowired
31+
private ApplicationContext applicationContext;
32+
33+
@Test
34+
void testConditionOnMissingClass_whenClassNotPresent() {
35+
assertFalse(applicationContext.containsBean("sseHttpClientTransportAutoConfiguration"));
36+
}
37+
38+
@Test
39+
void testConditionOnMissingClass_whenClassPresent() throws ClassNotFoundException {
40+
Class.forName("io.modelcontextprotocol.client.transport.WebFluxSseClientTransport");
41+
assertFalse(applicationContext.containsBean("sseHttpClientTransportAutoConfiguration"));
42+
}
43+
}

0 commit comments

Comments
 (0)