Skip to content

Commit 91f6cad

Browse files
committed
Improve JdbcChatMemoryRepository to simplify findConversationIds()
Signed-off-by: Yanming Zhou <[email protected]>
1 parent b219c21 commit 91f6cad

File tree

1 file changed

+1
-8
lines changed
  • memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc

1 file changed

+1
-8
lines changed

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,7 @@ private JdbcChatMemoryRepository(DataSource dataSource, JdbcChatMemoryRepository
7878

7979
@Override
8080
public List<String> findConversationIds() {
81-
List<String> conversationIds = this.jdbcTemplate.query(dialect.getSelectConversationIdsSql(), rs -> {
82-
var ids = new ArrayList<String>();
83-
while (rs.next()) {
84-
ids.add(rs.getString(1));
85-
}
86-
return ids;
87-
});
88-
return conversationIds != null ? conversationIds : List.of();
81+
return this.jdbcTemplate.queryForList(dialect.getSelectConversationIdsSql(), String.class);
8982
}
9083

9184
@Override

0 commit comments

Comments
 (0)