Skip to content

Commit b312dee

Browse files
committed
Accept response as a String instead of ChatResponse in EvaluationRequest
1 parent a1c4a29 commit b312dee

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

spring-ai-core/src/main/java/org/springframework/ai/evaluation/EvaluationRequest.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.springframework.ai.evaluation;
22

3-
import org.springframework.ai.chat.model.ChatResponse;
43
import org.springframework.ai.model.Content;
54

65
import java.util.List;
@@ -20,12 +19,12 @@ public class EvaluationRequest {
2019

2120
private final List<Content> dataList;
2221

23-
private final ChatResponse chatResponse;
22+
private final String responseContent;
2423

25-
public EvaluationRequest(String userText, List<Content> dataList, ChatResponse chatResponse) {
24+
public EvaluationRequest(String userText, List<Content> dataList, String responseContent) {
2625
this.userText = userText;
2726
this.dataList = dataList;
28-
this.chatResponse = chatResponse;
27+
this.responseContent = responseContent;
2928
}
3029

3130
public String getUserText() {
@@ -36,14 +35,14 @@ public List<Content> getDataList() {
3635
return dataList;
3736
}
3837

39-
public ChatResponse getChatResponse() {
40-
return chatResponse;
38+
public String getResponseContent() {
39+
return responseContent;
4140
}
4241

4342
@Override
4443
public String toString() {
4544
return "EvaluationRequest{" + "userText='" + userText + '\'' + ", dataList=" + dataList + ", chatResponse="
46-
+ chatResponse + '}';
45+
+ responseContent + '}';
4746
}
4847

4948
@Override
@@ -53,12 +52,12 @@ public boolean equals(Object o) {
5352
if (!(o instanceof EvaluationRequest that))
5453
return false;
5554
return Objects.equals(userText, that.userText) && Objects.equals(dataList, that.dataList)
56-
&& Objects.equals(chatResponse, that.chatResponse);
55+
&& Objects.equals(responseContent, that.responseContent);
5756
}
5857

5958
@Override
6059
public int hashCode() {
61-
return Objects.hash(userText, dataList, chatResponse);
60+
return Objects.hash(userText, dataList, responseContent);
6261
}
6362

6463
}

spring-ai-core/src/main/java/org/springframework/ai/evaluation/RelevancyEvaluator.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public RelevancyEvaluator(ChatClient.Builder chatClientBuilder) {
3030
@Override
3131
public EvaluationResponse evaluate(EvaluationRequest evaluationRequest) {
3232

33-
var response = doGetResponse(evaluationRequest);
33+
var response = evaluationRequest.getResponseContent();
3434
var context = doGetSupportingData(evaluationRequest);
3535

3636
String evaluationResponse = this.chatClientBuilder.build()
@@ -52,10 +52,6 @@ public EvaluationResponse evaluate(EvaluationRequest evaluationRequest) {
5252
return new EvaluationResponse(passing, score, "", Collections.emptyMap());
5353
}
5454

55-
protected String doGetResponse(EvaluationRequest evaluationRequest) {
56-
return evaluationRequest.getChatResponse().getResult().getOutput().getContent();
57-
}
58-
5955
protected String doGetSupportingData(EvaluationRequest evaluationRequest) {
6056
List<Content> data = evaluationRequest.getDataList();
6157
String supportingData = data.stream()

0 commit comments

Comments
 (0)