Improve JdbcChatMemoryRepository to simplify findConversationIds()

Signed-off-by: Yanming Zhou <[email protected]>

Author: quaff

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java

@@ -78,14 +78,7 @@ private JdbcChatMemoryRepository(DataSource dataSource, JdbcChatMemoryRepository
 
 	@Override
 	public List<String> findConversationIds() {
-		List<String> conversationIds = this.jdbcTemplate.query(dialect.getSelectConversationIdsSql(), rs -> {
-			var ids = new ArrayList<String>();
-			while (rs.next()) {
-				ids.add(rs.getString(1));
-			}
-			return ids;
-		});
-		return conversationIds != null ? conversationIds : List.of();
+		return this.jdbcTemplate.queryForList(dialect.getSelectConversationIdsSql(), String.class);
 	}
 
 	@Override

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/AbstractJdbcChatMemoryRepositoryIT.java

@@ -74,6 +74,8 @@ void saveMessagesSingleMessage(String content, MessageType messageType) {
 
 		chatMemoryRepository.saveAll(conversationId, List.of(message));
 
+		assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
+
 		// Use dialect to get the appropriate SQL query
 		JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect.from(jdbcTemplate.getDataSource());
 		String selectSql = dialect.getSelectMessagesSql()
@@ -96,6 +98,8 @@ void saveMessagesMultipleMessages() {
 
 		chatMemoryRepository.saveAll(conversationId, messages);
 
+		assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
+
 		// Use dialect to get the appropriate SQL query
 		JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect.from(jdbcTemplate.getDataSource());
 		String selectSql = dialect.getSelectMessagesSql()