fix attempts check logical

Signed-off-by: lambochen <[email protected]>

Author: lambochen

spring-ai-model/src/main/java/org/springframework/ai/model/tool/ToolExecutionEligibilityChecker.java

@@ -99,16 +99,13 @@ default boolean isInternalToolExecutionEnabled(ChatOptions chatOptions) {
 	default boolean isInternalToolExecutionEnabled(ChatOptions chatOptions, int attempts) {
 		boolean internalToolExecutionEnabled = isInternalToolExecutionEnabled(chatOptions);
 		if (!internalToolExecutionEnabled) {
-			return false;
+			return internalToolExecutionEnabled;
 		}
 
 		if (chatOptions instanceof ToolCallingChatOptions toolCallingChatOptions) {
 			return toolCallingChatOptions.getInternalToolExecutionMaxAttempts() == null
 					|| attempts <= toolCallingChatOptions.getInternalToolExecutionMaxAttempts();
 		}
-		else {
-			internalToolExecutionEnabled = true;
-		}
 		return internalToolExecutionEnabled;
 	}
 

spring-ai-model/src/main/java/org/springframework/ai/model/tool/ToolExecutionEligibilityPredicate.java

@@ -56,16 +56,13 @@ default boolean isToolExecutionRequired(ChatOptions promptOptions, ChatResponse
 	default boolean isToolExecutionRequired(ChatOptions promptOptions, ChatResponse chatResponse, int attempts) {
 		boolean isToolExecutionRequired = isToolExecutionRequired(promptOptions, chatResponse);
 		if (!isToolExecutionRequired) {
-			return true;
+			return isToolExecutionRequired;
 		}
 
 		if (promptOptions instanceof ToolCallingChatOptions toolCallingChatOptions) {
 			return toolCallingChatOptions.getInternalToolExecutionMaxAttempts() == null
 					|| attempts <= toolCallingChatOptions.getInternalToolExecutionMaxAttempts();
 		}
-		else {
-			isToolExecutionRequired = true;
-		}
 		return isToolExecutionRequired;
 	}