Skip to content

Commit d6f9b85

Browse files
committed
Make vector store builders extensible
- The VectorStore builders shouldn't be final as they are meant to be extensible - Suppress the `FinalClass` checkstyle errors on VectorStore classes
1 parent 6a53268 commit d6f9b85

File tree

8 files changed

+12
-8
lines changed

8 files changed

+12
-8
lines changed

spring-ai-core/src/main/java/org/springframework/ai/vectorstore/SimpleVectorStore.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import com.fasterxml.jackson.databind.ObjectMapper;
3939
import com.fasterxml.jackson.databind.ObjectWriter;
4040
import com.fasterxml.jackson.databind.json.JsonMapper;
41-
import io.micrometer.observation.ObservationRegistry;
4241
import org.slf4j.Logger;
4342
import org.slf4j.LoggerFactory;
4443

@@ -49,7 +48,6 @@
4948
import org.springframework.ai.util.JacksonUtils;
5049
import org.springframework.ai.vectorstore.observation.AbstractObservationVectorStore;
5150
import org.springframework.ai.vectorstore.observation.VectorStoreObservationContext;
52-
import org.springframework.ai.vectorstore.observation.VectorStoreObservationConvention;
5351
import org.springframework.core.io.Resource;
5452

5553
/**

src/checkstyle/checkstyle-suppressions.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,14 @@
4040

4141
<suppress files="AzureVectorStore.java" checks="FinalClass"/>
4242
<suppress files="CassandraVectorStore.java" checks="FinalClass"/>
43+
<suppress files="CoherenceVectorStore.java" checks="FinalClass"/>
44+
<suppress files="CosmosDBVectorStore.java" checks="FinalClass"/>
45+
<suppress files="GemFireVectorStore.java" checks="FinalClass"/>
4346
<suppress files="MilvusVectorStore.java" checks="FinalClass"/>
4447
<suppress files="HanaCloudVectorStore.java" checks="FinalClass"/>
48+
<suppress files="MongoDBAtlasVectorStore.java" checks="FinalClass"/>
49+
<suppress files="Neo4jVectorStore.java" checks="FinalClass"/>
50+
<suppress files="OpenSearchVectorStore.java" checks="FinalClass"/>
4551
<suppress files="PineconeVectorStore.java" checks="FinalClass"/>
4652
<suppress files="TypesenseVectorStore.java" checks="FinalClass"/>
4753
<suppress files="WeaviateVectorStore.java" checks="FinalClass"/>

vector-stores/spring-ai-azure-cosmos-db-store/src/main/java/org/springframework/ai/vectorstore/cosmosdb/CosmosDBVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ public VectorStoreObservationContext.Builder createObservationContextBuilder(Str
385385
*
386386
* @since 1.0.0
387387
*/
388-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
388+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
389389

390390
private final CosmosAsyncClient cosmosClient;
391391

vector-stores/spring-ai-coherence-store/src/main/java/org/springframework/ai/vectorstore/coherence/CoherenceVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ public VectorStoreObservationContext.Builder createObservationContextBuilder(Str
283283
*
284284
* @since 1.0.0
285285
*/
286-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
286+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
287287

288288
private final Session session;
289289

vector-stores/spring-ai-gemfire-store/src/main/java/org/springframework/ai/vectorstore/gemfire/GemFireVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ public void setDeleteData(boolean deleteData) {
562562
*
563563
* @since 1.0.0
564564
*/
565-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
565+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
566566

567567
private String host = GemFireVectorStore.DEFAULT_HOST;
568568

vector-stores/spring-ai-mongodb-atlas-store/src/main/java/org/springframework/ai/vectorstore/mongodb/atlas/MongoDBAtlasVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ public static Builder builder(MongoTemplate mongoTemplate, EmbeddingModel embedd
321321
return new Builder(mongoTemplate, embeddingModel);
322322
}
323323

324-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
324+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
325325

326326
private final MongoTemplate mongoTemplate;
327327

vector-stores/spring-ai-neo4j-store/src/main/java/org/springframework/ai/vectorstore/neo4j/Neo4jVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ public static Builder builder(Driver driver, EmbeddingModel embeddingModel) {
369369
return new Builder(driver, embeddingModel);
370370
}
371371

372-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
372+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
373373

374374
private final Driver driver;
375375

vector-stores/spring-ai-opensearch-store/src/main/java/org/springframework/ai/vectorstore/opensearch/OpenSearchVectorStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ public record OpenSearchDocument(String id, String content, Map<String, Object>
368368
/**
369369
* Builder class for creating OpenSearchVectorStore instances.
370370
*/
371-
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
371+
public static class Builder extends AbstractVectorStoreBuilder<Builder> {
372372

373373
private final OpenSearchClient openSearchClient;
374374

0 commit comments

Comments
 (0)