Skip to content

Commit e5422fd

Browse files
committed
Miscellaneous checkstyle fixes
Signed-off-by: Soby Chacko <[email protected]>
1 parent 5864255 commit e5422fd

File tree

212 files changed

+1203
-942
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

212 files changed

+1203
-942
lines changed

advisors/spring-ai-advisors-vector-store/src/main/java/org/springframework/ai/chat/client/advisor/vectorstore/QuestionAnswerAdvisor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@
2121
import java.util.Map;
2222
import java.util.stream.Collectors;
2323

24+
import reactor.core.publisher.Flux;
25+
import reactor.core.publisher.Mono;
26+
import reactor.core.scheduler.Schedulers;
27+
2428
import org.springframework.ai.chat.client.advisor.api.AdvisedRequest;
2529
import org.springframework.ai.chat.client.advisor.api.AdvisedResponse;
2630
import org.springframework.ai.chat.client.advisor.api.AdvisedResponseStreamUtils;
2731
import org.springframework.ai.chat.client.advisor.api.CallAroundAdvisor;
2832
import org.springframework.ai.chat.client.advisor.api.CallAroundAdvisorChain;
2933
import org.springframework.ai.chat.client.advisor.api.StreamAroundAdvisor;
3034
import org.springframework.ai.chat.client.advisor.api.StreamAroundAdvisorChain;
31-
import reactor.core.publisher.Flux;
32-
import reactor.core.publisher.Mono;
33-
import reactor.core.scheduler.Schedulers;
34-
3535
import org.springframework.ai.chat.model.ChatResponse;
3636
import org.springframework.ai.chat.prompt.PromptTemplate;
3737
import org.springframework.ai.document.Document;

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-jdbc/src/main/java/org/springframework/ai/model/chat/memory/jdbc/autoconfigure/JdbcChatMemoryDataSourceScriptDatabaseInitializer.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
/*
2+
* Copyright 2024-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
117
package org.springframework.ai.model.chat.memory.jdbc.autoconfigure;
218

319
import java.util.List;
@@ -13,7 +29,7 @@ class JdbcChatMemoryDataSourceScriptDatabaseInitializer extends DataSourceScript
1329

1430
private static final String SCHEMA_LOCATION = "classpath:org/springframework/ai/chat/memory/jdbc/schema-@@platform@@.sql";
1531

16-
public JdbcChatMemoryDataSourceScriptDatabaseInitializer(DataSource dataSource) {
32+
JdbcChatMemoryDataSourceScriptDatabaseInitializer(DataSource dataSource) {
1733
super(dataSource, getSettings(dataSource));
1834
}
1935

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-jdbc/src/test/java/org/springframework/ai/model/chat/memory/jdbc/autoconfigure/JdbcChatMemoryAutoConfigurationIT.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,14 @@ class JdbcChatMemoryAutoConfigurationIT {
6060

6161
@Test
6262
void jdbcChatMemoryScriptDatabaseInitializer_shouldBeLoaded() {
63-
this.contextRunner.withPropertyValues("spring.ai.chat.memory.jdbc.initialize-schema=true").run(context -> {
64-
assertThat(context.containsBean("jdbcChatMemoryScriptDatabaseInitializer")).isTrue();
65-
});
63+
this.contextRunner.withPropertyValues("spring.ai.chat.memory.jdbc.initialize-schema=true")
64+
.run(context -> assertThat(context.containsBean("jdbcChatMemoryScriptDatabaseInitializer")).isTrue());
6665
}
6766

6867
@Test
6968
void jdbcChatMemoryScriptDatabaseInitializer_shouldNotBeLoaded() {
70-
this.contextRunner.withPropertyValues("spring.ai.chat.memory.jdbc.initialize-schema=false").run(context -> {
71-
assertThat(context.containsBean("jdbcChatMemoryScriptDatabaseInitializer")).isFalse();
72-
});
69+
this.contextRunner.withPropertyValues("spring.ai.chat.memory.jdbc.initialize-schema=false")
70+
.run(context -> assertThat(context.containsBean("jdbcChatMemoryScriptDatabaseInitializer")).isFalse());
7371
}
7472

7573
@Test

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-jdbc/src/test/java/org/springframework/ai/model/chat/memory/jdbc/autoconfigure/JdbcChatMemoryDataSourceScriptDatabaseInitializerTests.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
/*
2+
* Copyright 2024-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
117
package org.springframework.ai.model.chat.memory.jdbc.autoconfigure;
218

319
import javax.sql.DataSource;

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-neo4j/src/main/java/org/springframework/ai/model/chat/memory/neo4j/autoconfigure/Neo4jChatMemoryAutoConfiguration.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.ai.model.chat.memory.neo4j.autoconfigure;
1818

1919
import org.neo4j.driver.Driver;
20+
2021
import org.springframework.ai.chat.memory.neo4j.Neo4jChatMemory;
2122
import org.springframework.ai.chat.memory.neo4j.Neo4jChatMemoryConfig;
2223
import org.springframework.boot.autoconfigure.AutoConfiguration;

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-neo4j/src/main/java/org/springframework/ai/model/chat/memory/neo4j/autoconfigure/Neo4jChatMemoryProperties.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,31 +42,31 @@ public class Neo4jChatMemoryProperties {
4242
private String mediaLabel = Neo4jChatMemoryConfig.DEFAULT_MEDIA_LABEL;
4343

4444
public String getSessionLabel() {
45-
return sessionLabel;
45+
return this.sessionLabel;
4646
}
4747

4848
public void setSessionLabel(String sessionLabel) {
4949
this.sessionLabel = sessionLabel;
5050
}
5151

5252
public String getToolCallLabel() {
53-
return toolCallLabel;
53+
return this.toolCallLabel;
5454
}
5555

5656
public String getMetadataLabel() {
57-
return metadataLabel;
57+
return this.metadataLabel;
5858
}
5959

6060
public String getMessageLabel() {
61-
return messageLabel;
61+
return this.messageLabel;
6262
}
6363

6464
public String getToolResponseLabel() {
65-
return toolResponseLabel;
65+
return this.toolResponseLabel;
6666
}
6767

6868
public String getMediaLabel() {
69-
return mediaLabel;
69+
return this.mediaLabel;
7070
}
7171

7272
public void setToolCallLabel(String toolCallLabel) {

auto-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-neo4j/src/test/java/org/springframework/ai/model/chat/memory/neo4j/autoconfigure/Neo4jChatMemoryPropertiesTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.ai.model.chat.memory.neo4j.autoconfigure;
1818

1919
import org.junit.jupiter.api.Test;
20+
2021
import org.springframework.ai.chat.memory.neo4j.Neo4jChatMemoryConfig;
2122

2223
import static org.assertj.core.api.Assertions.assertThat;

auto-configurations/models/spring-ai-autoconfigure-model-anthropic/src/main/java/org/springframework/ai/model/anthropic/autoconfigure/AnthropicChatAutoConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@
2020

2121
import org.springframework.ai.anthropic.AnthropicChatModel;
2222
import org.springframework.ai.anthropic.api.AnthropicApi;
23+
import org.springframework.ai.chat.observation.ChatModelObservationConvention;
2324
import org.springframework.ai.model.SpringAIModelProperties;
2425
import org.springframework.ai.model.SpringAIModels;
25-
import org.springframework.ai.model.tool.autoconfigure.ToolCallingAutoConfiguration;
26-
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
27-
import org.springframework.ai.chat.observation.ChatModelObservationConvention;
2826
import org.springframework.ai.model.function.DefaultFunctionCallbackResolver;
2927
import org.springframework.ai.model.function.FunctionCallbackResolver;
3028
import org.springframework.ai.model.tool.DefaultToolExecutionEligibilityPredicate;
3129
import org.springframework.ai.model.tool.ToolCallingManager;
3230
import org.springframework.ai.model.tool.ToolExecutionEligibilityPredicate;
31+
import org.springframework.ai.model.tool.autoconfigure.ToolCallingAutoConfiguration;
32+
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
3333
import org.springframework.beans.factory.ObjectProvider;
3434
import org.springframework.boot.autoconfigure.AutoConfiguration;
3535
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;

auto-configurations/models/spring-ai-autoconfigure-model-anthropic/src/test/java/org/springframework/ai/model/anthropic/autoconfigure/AnthropicModelConfigurationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ public class AnthropicModelConfigurationTests {
3737

3838
@Test
3939
void chatModelActivation() {
40-
this.contextRunner.run(context -> {
41-
assertThat(context.getBeansOfType(AnthropicChatModel.class)).isNotEmpty();
42-
});
40+
this.contextRunner.run(context -> assertThat(context.getBeansOfType(AnthropicChatModel.class)).isNotEmpty());
4341

4442
this.contextRunner.withPropertyValues("spring.ai.model.chat=none").run(context -> {
4543
assertThat(context.getBeansOfType(AnthropicChatProperties.class)).isEmpty();

auto-configurations/models/spring-ai-autoconfigure-model-anthropic/src/test/java/org/springframework/ai/model/anthropic/autoconfigure/AnthropicPropertiesTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,7 @@ public void chatCompletionDisabled() {
121121
new ApplicationContextRunner().withPropertyValues("spring.ai.model.chat=none")
122122
.withConfiguration(AutoConfigurations.of(SpringAiRetryAutoConfiguration.class,
123123
RestClientAutoConfiguration.class, AnthropicChatAutoConfiguration.class))
124-
.run(context -> {
125-
assertThat(context.getBeansOfType(AnthropicChatModel.class)).isEmpty();
126-
});
124+
.run(context -> assertThat(context.getBeansOfType(AnthropicChatModel.class)).isEmpty());
127125
}
128126

129127
}

0 commit comments

Comments
 (0)