Skip to content

Commit f0702c3

Browse files
ilayaperumalgmarkpollack
authored andcommitted
Remove deprecated FunctionCallback references
- Remove the deprecated FunctionCallback related classes, references - Replace them with the corresponding ToolCallback usage Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
1 parent 22c778f commit f0702c3

File tree

55 files changed

+102
-3216
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+102
-3216
lines changed

auto-configurations/models/spring-ai-autoconfigure-model-bedrock-ai/src/main/java/org/springframework/ai/model/bedrock/converse/autoconfigure/BedrockConverseProxyChatProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public ToolCallingChatOptions getOptions() {
4444
}
4545

4646
public void setOptions(ToolCallingChatOptions options) {
47-
Assert.notNull(options, "FunctionCallingOptions must not be null");
47+
Assert.notNull(options, "ToolCallingChatOptions must not be null");
4848
this.options = options;
4949
}
5050

auto-configurations/models/spring-ai-autoconfigure-model-minimax/src/test/java/org/springframework/ai/model/minimax/autoconfigure/FunctionCallbackInPromptIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.springframework.ai.chat.prompt.Prompt;
3333
import org.springframework.ai.minimax.MiniMaxChatModel;
3434
import org.springframework.ai.minimax.MiniMaxChatOptions;
35-
import org.springframework.ai.model.function.FunctionCallback;
3635
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
3736
import org.springframework.ai.tool.function.FunctionToolCallback;
3837
import org.springframework.boot.autoconfigure.AutoConfigurations;

auto-configurations/models/spring-ai-autoconfigure-model-minimax/src/test/java/org/springframework/ai/model/minimax/autoconfigure/FunctionCallbackWithPlainFunctionBeanIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.springframework.ai.chat.prompt.Prompt;
3434
import org.springframework.ai.minimax.MiniMaxChatModel;
3535
import org.springframework.ai.minimax.MiniMaxChatOptions;
36-
import org.springframework.ai.model.function.FunctionCallingOptions;
3736
import org.springframework.ai.model.tool.ToolCallingChatOptions;
3837
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
3938
import org.springframework.boot.autoconfigure.AutoConfigurations;

auto-configurations/models/spring-ai-autoconfigure-model-minimax/src/test/java/org/springframework/ai/model/minimax/autoconfigure/MiniMaxFunctionCallbackIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.springframework.ai.chat.prompt.Prompt;
3333
import org.springframework.ai.minimax.MiniMaxChatModel;
3434
import org.springframework.ai.minimax.MiniMaxChatOptions;
35-
import org.springframework.ai.model.function.FunctionCallback;
3635
import org.springframework.ai.model.tool.autoconfigure.ToolCallingAutoConfiguration;
3736
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
3837
import org.springframework.ai.tool.function.FunctionToolCallback;

auto-configurations/models/spring-ai-autoconfigure-model-ollama/src/test/kotlin/org/springframework/ai/model/ollama/autoconfigure/tool/FunctionCallbackContextKotlinIT.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class FunctionCallbackResolverKotlinIT : BaseOllamaIT() {
5959
.withUserConfiguration(Config::class.java)
6060

6161
@Test
62-
fun functionCallTest() {
62+
fun toolCallTest() {
6363
this.contextRunner.run {context ->
6464

6565
val chatModel = context.getBean(OllamaChatModel::class.java)
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import org.springframework.context.annotation.Configuration
3333
import org.springframework.context.annotation.Description
3434

3535

36-
class FunctionCallbackKotlinIT : BaseOllamaIT() {
36+
class ToolCallbackKotlinIT : BaseOllamaIT() {
3737

3838
companion object {
3939

@@ -46,7 +46,7 @@ class FunctionCallbackKotlinIT : BaseOllamaIT() {
4646
}
4747
}
4848

49-
private val logger = LoggerFactory.getLogger(FunctionCallbackKotlinIT::class.java)
49+
private val logger = LoggerFactory.getLogger(ToolCallbackKotlinIT::class.java)
5050

5151
private val contextRunner = ApplicationContextRunner()
5252
.withPropertyValues(
@@ -59,7 +59,7 @@ class FunctionCallbackKotlinIT : BaseOllamaIT() {
5959
.withUserConfiguration(Config::class.java)
6060

6161
@Test
62-
fun functionCallTest() {
62+
fun toolCallTest() {
6363
this.contextRunner.run {context ->
6464

6565
val chatModel = context.getBean(OllamaChatModel::class.java)

auto-configurations/models/spring-ai-autoconfigure-model-vertex-ai/src/main/java/org/springframework/ai/model/vertexai/autoconfigure/gemini/VertexAiGeminiChatAutoConfiguration.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,16 +113,4 @@ public VertexAiGeminiChatModel vertexAiGeminiChat(VertexAI vertexAi, VertexAiGem
113113
return chatModel;
114114
}
115115

116-
/**
117-
* Because of the OPEN_API_SCHEMA type, the FunctionCallbackResolver instance must
118-
* different from the other JSON schema types.
119-
*/
120-
// private FunctionCallbackResolver springAiFunctionManager(ApplicationContext
121-
// context) {
122-
// DefaultFunctionCallbackResolver manager = new DefaultFunctionCallbackResolver();
123-
// manager.setSchemaType(SchemaType.OPEN_API_SCHEMA);
124-
// manager.setApplicationContext(context);
125-
// return manager;
126-
// }
127-
128116
}

auto-configurations/models/spring-ai-autoconfigure-model-vertex-ai/src/test/java/org/springframework/ai/model/vertexai/autoconfigure/gemini/tool/FunctionCallWithFunctionBeanIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.ai.chat.messages.UserMessage;
2828
import org.springframework.ai.chat.model.ChatResponse;
2929
import org.springframework.ai.chat.prompt.Prompt;
30-
import org.springframework.ai.model.function.FunctionCallingOptions;
30+
import org.springframework.ai.model.tool.ToolCallingChatOptions;
3131
import org.springframework.ai.model.vertexai.autoconfigure.gemini.VertexAiGeminiChatAutoConfiguration;
3232
import org.springframework.ai.vertexai.gemini.VertexAiGeminiChatModel;
3333
import org.springframework.ai.vertexai.gemini.VertexAiGeminiChatOptions;
@@ -109,7 +109,7 @@ void functionCallWithPortableFunctionCallingOptions() {
109109
""");
110110

111111
ChatResponse response = chatModel.call(new Prompt(List.of(userMessage),
112-
FunctionCallingOptions.builder().function("weatherFunction").build()));
112+
ToolCallingChatOptions.builder().toolNames("weatherFunction").build()));
113113

114114
logger.info("Response: {}", response);
115115

auto-configurations/models/spring-ai-autoconfigure-model-zhipuai/src/test/java/org/springframework/ai/model/zhipuai/autoconfigure/tool/FunctionCallbackInPromptIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import org.springframework.ai.chat.model.ChatResponse;
3131
import org.springframework.ai.chat.model.Generation;
3232
import org.springframework.ai.chat.prompt.Prompt;
33-
import org.springframework.ai.model.function.FunctionCallback;
3433
import org.springframework.ai.model.zhipuai.autoconfigure.ZhiPuAiChatAutoConfiguration;
3534
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
3635
import org.springframework.ai.tool.function.FunctionToolCallback;

auto-configurations/models/spring-ai-autoconfigure-model-zhipuai/src/test/java/org/springframework/ai/model/zhipuai/autoconfigure/tool/FunctionCallbackWithPlainFunctionBeanIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.springframework.ai.chat.model.ChatResponse;
3232
import org.springframework.ai.chat.model.Generation;
3333
import org.springframework.ai.chat.prompt.Prompt;
34-
import org.springframework.ai.model.function.FunctionCallingOptions;
3534
import org.springframework.ai.model.tool.ToolCallingChatOptions;
3635
import org.springframework.ai.model.zhipuai.autoconfigure.ZhiPuAiChatAutoConfiguration;
3736
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;

0 commit comments

Comments
 (0)