Adding a Document to a neo4j vector store needlessly overwrites all its properties

[enricorampazzo]

spring-ai/vector-stores/spring-ai-neo4j-store/src/main/java/org/springframework/ai/vectorstore/Neo4jVectorStore.java

Line 125 in 9e18652

SET u = {}

Because of this line, when an existing node is added to the vector store, its existing properties are deleted, and only those added as document metadata are persisted.

This is needlessly destructive. I suggest to change line 125 to SET u = properties(u) so that existing properties are preserved

[meistermeier]

It was there since the beginning, but I have no exact idea why we / I did this anymore.
I think it was because we wanted to persist the document as it comes in . But if it makes trouble, I have no problem in removing those lines and compress it.

[enricorampazzo]

Maybe I am using it wrongly, but what I normally do is I create records in a db, with some text I want to embed, and if I want to use that record later, all its properties will be removed, unless I set them in the metadata, which seems clunky, but again, maybe I am missing something

[meistermeier]

There is now the PR (#2070) for this. I also would say it's ok to keep the existing properties.

[sobychacko]

Looks good. Merged the changes upstream. Thanks for looking into it.