Wrong message order for JDBC Chat Memory

[xjh1994]

Every time a new message is generated in the same conversation, all previous messages will be deleted first and then inserted.

public void saveAll(String conversationId, List<Message> messages) {
        // ……
        this.deleteByConversationId(conversationId);
        this.jdbcTemplate.batchUpdate(this.dialect.getInsertMessageSql(), new AddBatchPreparedStatement(conversationId, messages));
    }

While timestamp in AddBatchPreparedStatement is set to current time every time, which leads to the same timestamp for each messages in this conversation.

public void setValues(PreparedStatement ps, int i) throws SQLException {
            // ……
            ps.setTimestamp(4, new Timestamp(this.instantSeq.getAndIncrement()));
        }

[xjh1994]

version: 1.0.0-RC1

[jingsewu]

Yes, and I think the saveAll function should add @transactional to ensure the data consistency

[sunyuhan1998]

I pushed a PR #3154 to fix this issues

[markpollack]

This has now been fixed in the commit 31da8f3 thanks for all who reported.

[xjh1994]

not resolved

[sunyuhan1998]

not resolved

I guess you're referring to the timestamp issue. In fact, as @markpollack mentioned, the timestamp field is not actually a field that represents the "message sending time"—it's simply an auto-incrementing sequence. The name of this field is misleading, and it will be adjusted in the future.

Additionally, what ChatMemoryRepository stores is not exactly "historical conversation messages"; it's more like a message window that ensures the total number of messages does not exceed a specified limit. When the number of messages exceeds the maximum size, older messages are evicted.