Skip to content

Make default ChatOptions specific #4606

@markusheiden

Description

@markusheiden

Expected Behavior

Specific chat models return specific default chat options (e.g. OpenAiChatOptions).

public class OpenAiChatModel {
	@Override
	public OpenAiChatOptions getDefaultOptions() {
		return OpenAiChatOptions.fromOptions(this.defaultOptions);
	}
}

Current Behavior

Specific chat models return generic default options (ChatOptions).

public class OpenAiChatModel {
	@Override
	public ChatOptions getDefaultOptions() {
		return OpenAiChatOptions.fromOptions(this.defaultOptions);
	}
}

Context

I want to use some of the default options to build my custom chat options. To ease that, it would be nice to not have to cast the default options to their specific type.

OpenAiChatOptions defaultOptions = (OpenAiChatOptions) chatModel.getDefaultOptions();
OpenAiChatOptions options = ...
options.setUser(defaultOptions.getUser());

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions